You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@reef.apache.org by Yunseong Lee <yu...@gmail.com> on 2016/01/19 07:39:21 UTC

PR is not closed after merging

Hi all,

I merged https://github.com/apache/reef/pull/768 to the master, but I
accidentally missed to add 'This closes', which has made the PR still open.

Does anybody know how I can fix this mistake?


Sorry for the inconvenience.

Best regards,
Yunseong

Re: PR is not closed after merging

Posted by Dongjoon Hyun <do...@apache.org>.

It sounds good. I did the same mistake before, too.
If we have that kind of guideline for these cases, our review process will
become more robust and faster.

Warmly,
Dongjoon.

On Tue, Jan 19, 2016 at 9:00 AM, Markus Weimer <ma...@weimo.de> wrote:

> Yeah, this is quite annoying. Eventually, our good-will  and attention
> based approach to PR closing will stop working, e.g. with stale PRs (*ahem*
> Boris *ahem*).
>
> Spark does this thing where they make commits purely to instruct GitHub to
> close PRs. We could follow the same approach, e.g. by adding a
> `dev/pullrequests.txt` to which we add a line each time we close a PR and
> why.
>
> I'm not sure we need that yet, but eventually, we will. Maybe there are
> better / more elegant solutions out there?
>
> Markus
>

Re: PR is not closed after merging

Posted by Markus Weimer <ma...@weimo.de>.

Yeah, this is quite annoying. Eventually, our good-will  and attention 
based approach to PR closing will stop working, e.g. with stale PRs 
(*ahem* Boris *ahem*).

Spark does this thing where they make commits purely to instruct GitHub 
to close PRs. We could follow the same approach, e.g. by adding a 
`dev/pullrequests.txt` to which we add a line each time we close a PR 
and why.

I'm not sure we need that yet, but eventually, we will. Maybe there are 
better / more elegant solutions out there?

Markus

Re: PR is not closed after merging

Posted by Yunseong Lee <yu...@gmail.com>.

Thanks a lot, Andrew!
I'll mark the JIRA issue as resolved.

Regards,
Yunseong


On Tue, Jan 19, 2016 at 3:31 PM, Andrew Chung <af...@gmail.com> wrote:

> PR to be closed. In this case, I'll close my own PR :).
>

Re: PR is not closed after merging

Posted by Andrew Chung <af...@gmail.com>.

Hi Yunseong,

I've made the same mistake before and I was advised to simply ask for the
PR to be closed. In this case, I'll close my own PR :).

Thanks,
Andrew

On Mon, Jan 18, 2016 at 10:39 PM, Yunseong Lee <yu...@gmail.com>
wrote:

> Hi all,
>
> I merged https://github.com/apache/reef/pull/768 to the master, but I
> accidentally missed to add 'This closes', which has made the PR still open.
>
> Does anybody know how I can fix this mistake?
>
>
> Sorry for the inconvenience.
>
> Best regards,
> Yunseong
>