You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jvwing <gi...@git.apache.org> on 2017/04/19 04:22:47 UTC

[GitHub] nifi pull request #1680: NIFI-3710: Port S3 Signer V4 Fixes to 0.x

GitHub user jvwing opened a pull request:

    https://github.com/apache/nifi/pull/1680

    NIFI-3710: Port S3 Signer V4 Fixes to 0.x

    * Port of S3 changes for selecting the S3 signer to allow v2 or v4.
    * Necessary for supporting S3-compatible, non-AWS stores in recent SDKs.
    * Includes original code from NIFI-2763 and fix from NIFI-2902.
    
    ----
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jvwing/nifi NIFI-3710-0x-aws-v4-signer-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1680
    
----
commit 239dd50092f8273acf575e41e9828a0fb9a0d476
Author: d810146 <na...@team.telstra.com>
Date:   2016-09-28T06:16:21Z

    NIFI-3710: Port S3 Signer V4 Fixes to 0.x
    
    * Port of S3 changes for selecting the S3 signer to allow v2 or v4.
    * Necessary for supporting S3-compatible, non-AWS stores in recent SDKs.
    * Includes original code from NIFI-2763 and fix from NIFI-2902.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1680: NIFI-3710: Port S3 Signer V4 Fixes to 0.x

Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/1680
  
    Builds and executes as expected, and resolves the issue.  Thanks @jvwing.
    +1 will merge to 0.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1680: NIFI-3710: Port S3 Signer V4 Fixes to 0.x

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1680
  
    Thanks, @mosermw 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1680: NIFI-3710: Port S3 Signer V4 Fixes to 0.x

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing closed the pull request at:

    https://github.com/apache/nifi/pull/1680


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1680: NIFI-3710: Port S3 Signer V4 Fixes to 0.x

Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/1680
  
    reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---