You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/06/03 05:21:51 UTC
[GitHub] [systemml] wizard-420 opened a new pull request #940: Outlier
wizard-420 opened a new pull request #940:
URL: https://github.com/apache/systemml/pull/940
How to initialize a boolean variable in dml?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 commented on pull request #940: [DOC] Documentation for builtin toOnehot function
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-637960768
> How to initialize a boolean variable in dml?
For a variable add `0` or `1`, that would automatically allocates `double` or `boolean`.
For example:
```
x = 0;
```
Now, `x` can be considered `false`.
DML figures out `x` should used as a boolean or not based on usage of the`x` in the program.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 edited a comment on pull request #940: [DOC] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
j143 edited a comment on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-637960768
> How to initialize a boolean variable in dml?
For a variable add `0` or `1`, that would automatically allocates `double` or `boolean`.
For example:
```
x = 0;
```
Now, `x` can be considered `false`.
DML figures out `x` should used as a boolean or not based on usage of the`x` in the program.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] asfgit closed pull request #940: [DOC][1/3] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #940:
URL: https://github.com/apache/systemml/pull/940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 commented on a change in pull request #940: Outlier
Posted by GitBox <gi...@apache.org>.
j143 commented on a change in pull request #940:
URL: https://github.com/apache/systemml/pull/940#discussion_r434313371
##########
File path: dev/docs/builtins-reference.md
##########
@@ -322,3 +322,11 @@ y = X %*% rand(rows=ncol(X), 1)
w = lm(X = X, y = y)
ress = slicefinder(X = X,W = w, Y = y, k = 5, paq = 1, S = 2);
```
+##outlier-Function
Review comment:
Thanks a lot, @wizard-420 ! Try to add usage and example and follow the same pattern as used for other functions. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 commented on pull request #940: [DOC] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-637966180
Hi @wizard-420 - please move the discussion to this place regarding `outlier` function, this way we are more likely receive other contributors help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] wizard-420 commented on a change in pull request #940: [DOC] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
wizard-420 commented on a change in pull request #940:
URL: https://github.com/apache/systemml/pull/940#discussion_r434324580
##########
File path: dev/docs/builtins-reference.md
##########
@@ -322,3 +322,11 @@ y = X %*% rand(rows=ncol(X), 1)
w = lm(X = X, y = y)
ress = slicefinder(X = X,W = w, Y = y, k = 5, paq = 1, S = 2);
```
+##outlier-Function
Review comment:
I have added the contents. please check if everything is alright
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] wizard-420 commented on a change in pull request #940: [DOC] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
wizard-420 commented on a change in pull request #940:
URL: https://github.com/apache/systemml/pull/940#discussion_r434314035
##########
File path: dev/docs/builtins-reference.md
##########
@@ -322,3 +322,11 @@ y = X %*% rand(rows=ncol(X), 1)
w = lm(X = X, y = y)
ress = slicefinder(X = X,W = w, Y = y, k = 5, paq = 1, S = 2);
```
+##outlier-Function
Review comment:
I need help with how to initialize a boolean data type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] wizard-420 removed a comment on pull request #940: [DOC][1/3] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
wizard-420 removed a comment on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-637998271
ok I will get on it asap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 commented on pull request #940: [DOC] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-637979047
Now, you might want to work on `outlierByIQR` https://github.com/apache/systemml/blob/faec15810e18fc497e950b830811a919f5aa5c5f/scripts/builtin/outlierByIQR.dml#L23
in a different PR. I will review this and merge this later today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] wizard-420 commented on a change in pull request #940: [DOC] Documentation for builtin toOnehot function
Posted by GitBox <gi...@apache.org>.
wizard-420 commented on a change in pull request #940:
URL: https://github.com/apache/systemml/pull/940#discussion_r434314035
##########
File path: dev/docs/builtins-reference.md
##########
@@ -322,3 +322,11 @@ y = X %*% rand(rows=ncol(X), 1)
w = lm(X = X, y = y)
ress = slicefinder(X = X,W = w, Y = y, k = 5, paq = 1, S = 2);
```
+##outlier-Function
Review comment:
I need help with how to initialize a boolean data type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] wizard-420 commented on pull request #940: [DOC] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
wizard-420 commented on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-637998271
ok I will get on it asap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 removed a comment on pull request #940: [DOC][1/3] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
j143 removed a comment on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-637966180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 commented on pull request #940: [DOC][1/3] Documentation for builtin Outlier function
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #940:
URL: https://github.com/apache/systemml/pull/940#issuecomment-640418927
Thank you, @wizard-420 - LGTM. 👍
🎉 🚀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org