You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "ianmcook (via GitHub)" <gi...@apache.org> on 2023/05/01 22:56:49 UTC

[GitHub] [arrow] ianmcook commented on pull request #34919: GH-34918: [C++] Update vendored double-conversion

ianmcook commented on PR #34919:
URL: https://github.com/apache/arrow/pull/34919#issuecomment-1530497802

   @liujiacheng777 As Kou says above, there were a few small changes made to the vendored double-conversion in #9816. It  https://github.com/apache/arrow/pull/9816/files#diff-d1cc5b70a5e980626bb70ae604a050d3393ac25a717a5a4c8dc40e8b5caf4b05
   It looks like they were very small changes: less than 10 lines of code added, plus some comments. Could you please push a commit to this PR that ports these changes to the vendored double-conversion 3.2.1?
   
   As Kou says above, we would like to upstream these changes, but porting the changes here will help, and I think it will fix the failing CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org