You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/11 15:16:19 UTC

[GitHub] [trafficserver] ywkaras commented on a change in pull request #7100: Fixes uninitialized variables found by Xcode

ywkaras commented on a change in pull request #7100:
URL: https://github.com/apache/trafficserver/pull/7100#discussion_r468660369



##########
File path: proxy/http/HttpBodyFactory.cc
##########
@@ -372,8 +372,8 @@ HttpBodyFactory::fabricate(StrList *acpt_language_list, StrList *acpt_charset_li
   char *buffer;
   const char *pType = context->txn_conf->body_factory_template_base;
   const char *set;
-  HttpBodyTemplate *t = nullptr;
-  HttpBodySet *body_set;
+  HttpBodyTemplate *t   = nullptr;

Review comment:
       Seems better to also move this to right before line 412 to make code more readable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org