You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/17 07:05:17 UTC

[GitHub] [incubator-nuttx] btashton commented on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

btashton commented on pull request #1816:
URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694006589


   @patacongo I have a related question about this driver.  It seems like a lot more is exposed in the `stmpe811.h` header than we should in the "public" interface.  This is causing issues when I add the board integration since it defines `GPIO_PIN(n)` which is a common define for chips.
   
   ```
   In file included from nrf52-feather.h:46,
                    from nrf52_stmpe811.c:42:
   /home/bashton/nuttx/apache/incubator-nuttx/arch/arm/src/chip/nrf52_gpio.h:178: warning: "GPIO_PIN" redefined
    #  define GPIO_PIN(n)           ((n) << GPIO_PIN_SHIFT)
    
   In file included from nrf52_stmpe811.c:34:
   /home/bashton/nuttx/apache/incubator-nuttx/include/nuttx/input/stmpe811.h:282: note: this is the location of the previous definition
    #define GPIO_PIN(n)                  (1 << (n))
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org