[jira] [Work logged] (HIVE-17331) Path must be used as key type of the pathToAlises

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-17331?focusedWorklogId=446704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446704 ]

ASF GitHub Bot logged work on HIVE-17331:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jun/20 16:55
            Start Date: 16/Jun/20 16:55
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] commented on pull request #292:
URL: https://github.com/apache/hive/pull/292#issuecomment-644886870


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 446704)
    Remaining Estimate: 0h
            Time Spent: 10m

> Path must be used as key type of the pathToAlises
> -------------------------------------------------
>
>                 Key: HIVE-17331
>                 URL: https://issues.apache.org/jira/browse/HIVE-17331
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17331.2.patch, HIVE-17331.3.patch, HIVE-17331.4.patch, HIVE-17331.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This code uses String instead of Path as key type of the pathToAliases map, so seems like get(String) always null.
> +*GenMapRedUtils.java*+
> {code:java}
>         for (int pos = 0; pos < size; pos++) {
>           String taskTmpDir = taskTmpDirLst.get(pos);
>           TableDesc tt_desc = tt_descLst.get(pos);
>           MapWork mWork = plan.getMapWork();
>           if (mWork.getPathToAliases().get(taskTmpDir) == null) {
>             taskTmpDir = taskTmpDir.intern();
>             Path taskTmpDirPath = StringInternUtils.internUriStringsInPath(new Path(taskTmpDir));
>             mWork.removePathToAlias(taskTmpDirPath);
>             mWork.addPathToAlias(taskTmpDirPath, taskTmpDir);
>             mWork.addPathToPartitionInfo(taskTmpDirPath, new PartitionDesc(tt_desc, null));
>             mWork.getAliasToWork().put(taskTmpDir, topOperators.get(pos));
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)