[GitHub] [pinot] KKcorps commented on a change in pull request #8382: builtin datetime functions to avoid throwing NullPointerException when input value is null

[GitBox <gi...@apache.org>]

KKcorps commented on a change in pull request #8382:
URL: https://github.com/apache/pinot/pull/8382#discussion_r835083701



##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/InbuiltFunctionEvaluator.java
##########
@@ -138,6 +149,15 @@ public Object execute(Object[] values) {
         for (int i = 0; i < numArguments; i++) {
           _arguments[i] = _argumentNodes[i].execute(values);
         }
+        if (!_functionInfo.hasNullableParameters()) {

Review comment:
       @Jackie-Jiang with this logic, by default, for all of our scalar functions if an argument is null we will return null instead of throwing exception. Is this fine?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org