You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/03/24 07:29:05 UTC

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18350


Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
A src/kudu/duplicator/kafka/mock_kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
68 files changed, 2,612 insertions(+), 75 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18350 )

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................


Patch Set 3:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/common/types.h
File src/kudu/common/types.h:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/common/types.h@65
PS3, Line 65:   const size_t size() const { return size_; }
> warning: return type 'const size_t' (aka 'const unsigned long') is 'const'-
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/connector.h
File src/kudu/duplicator/connector.h:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/connector.h@48
PS3, Line 48:                const std::shared_ptr<Schema>& p_schema_ptr,
> warning: pass by value and use std::move [modernize-pass-by-value]
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.h
File src/kudu/duplicator/duplicator.h:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.h@57
PS3, Line 57:   const consensus::OpId last_confirmed_opid() const {
> warning: return type 'const consensus::OpId' is 'const'-qualified at the to
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.cc
File src/kudu/duplicator/duplicator.cc:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.cc@109
PS3, Line 109:   // TODO deal queue data
> warning: missing username/bug in TODO [google-readability-todo]
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/kafka_connector.h
File src/kudu/duplicator/kafka/kafka_connector.h:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/kafka_connector.h@68
PS3, Line 68: using std::map;
> warning: using declarations in the global namespace in headers are prohibit
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/kafka_connector.h@69
PS3, Line 69: using std::string;
> warning: using declarations in the global namespace in headers are prohibit
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/mock_kafka_connector.h
File src/kudu/duplicator/kafka/mock_kafka_connector.h:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/mock_kafka_connector.h@33
PS3, Line 33:   explicit MockProducer(const Configuration /* config */) : timeout_ms_(30000) {}
> warning: the const qualified parameter #1 is copied for each invocation; co
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/ops/op_driver.cc
File src/kudu/tablet/ops/op_driver.cc:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/ops/op_driver.cc@294
PS3, Line 294:     if (op_->type() == consensus::FOLLOWER) {
> warning: repeated branch in conditional chain [bugprone-branch-clone]
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:

http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/tablet_replica.cc@193
PS3, Line 193: TabletReplica::TabletReplica(const consensus::RaftPeerPB& local_peer_pb) :
> warning: pass by value and use std::move [modernize-pass-by-value]
Done


http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/tablet_replica.cc@1389
PS3, Line 1389:     deque<std::shared_ptr<WriteOpState>> ops) {
> warning: the parameter 'ops' is copied for each invocation but only used as
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 04:29:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#3).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
A src/kudu/duplicator/kafka/mock_kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
67 files changed, 2,643 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#10).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-proto/build.gradle
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
70 files changed, 2,615 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 10
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18350 )

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................


Patch Set 2:

(45 comments)

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/common/types-test.cc
File src/kudu/common/types-test.cc:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/common/types-test.cc@138
PS2, Line 138:       string slower, supper;
> warning: multiple declarations in a single statement reduces readability [r
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/common/types.h
File src/kudu/common/types.h:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/common/types.h@65
PS2, Line 65:   const size_t size() const { return size_; }
> warning: return type 'const size_t' (aka 'const unsigned long') is 'const'-
reserve it


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/consensus/quorum_util.h
File src/kudu/consensus/quorum_util.h:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/consensus/quorum_util.h@118
PS2, Line 118: bool ShouldAddDuplicator(const RaftConfigPB& config,
> warning: function 'kudu::consensus::ShouldAddDuplicator' has a definition w
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/consensus/quorum_util.cc
File src/kudu/consensus/quorum_util.cc:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/consensus/quorum_util.cc@541
PS2, Line 541:                       const unordered_set<string>& uuids_ignored_for_underreplication) {
> warning: parameter 'uuids_ignored_for_underreplication' is unused [misc-unu
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h
File src/kudu/duplicator/connector.h:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@46
PS2, Line 46:   DuplicateMsg(const std::shared_ptr<tablet::WriteOpState>& _op_state,
> warning: invalid case style for parameter '_op_state' [readability-identifi
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@47
PS2, Line 47:                const tablet::RowOp* _row_op,
> warning: invalid case style for parameter '_row_op' [readability-identifier
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@48
PS2, Line 48:                const std::shared_ptr<Schema>& _schema_ptr,
> warning: invalid case style for parameter '_schema_ptr' [readability-identi
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@49
PS2, Line 49:                const std::string& _table_name)
> warning: invalid case style for parameter '_table_name' [readability-identi
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@79
PS2, Line 79:   LocalConnector() : Connector() {}
> warning: initializer for base class 'kudu::duplicator::Connector' is redund
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@80
PS2, Line 80:   virtual ~LocalConnector() = default;
> warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@85
PS2, Line 85:   RemoteConnector() : Connector() {}
> warning: initializer for base class 'kudu::duplicator::Connector' is redund
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@86
PS2, Line 86:   virtual ~RemoteConnector() = default;
> warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@97
PS2, Line 97:   KuduLocalConnector() : LocalConnector() {}
> warning: initializer for base class 'kudu::duplicator::LocalConnector' is r
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@98
PS2, Line 98:   virtual ~KuduLocalConnector() = default;
> warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@99
PS2, Line 99:   virtual Status Init() override {
> warning: 'virtual' is redundant since the function is already declared 'ove
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/connector.h@103
PS2, Line 103:   virtual Status WriteBatch(const std::vector<std::shared_ptr<DuplicateMsg>>& /* msgs */) override {
> warning: 'virtual' is redundant since the function is already declared 'ove
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.h
File src/kudu/duplicator/duplicator.h:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.h@57
PS2, Line 57:     const consensus::OpId last_confirmed_opid() const {
> warning: return type 'const consensus::OpId' is 'const'-qualified at the to
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.h@68
PS2, Line 68:     // TODO use pointer to avoid copy
> warning: missing username/bug in TODO [google-readability-todo]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.cc
File src/kudu/duplicator/duplicator.cc:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.cc@54
PS2, Line 54: static bool ValidateDownstreamFlag(const char* flagname, const std::string& value) {
> warning: parameter 'flagname' is unused [misc-unused-parameters]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.cc@66
PS2, Line 66: Duplicator::Duplicator(ThreadPool* thread_pool, const std::string& table_name)
> warning: pass by value and use std::move [modernize-pass-by-value]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.cc@95
PS2, Line 95:                                                     // TODO metric_entity for duplicate_pool_
> warning: missing username/bug in TODO [google-readability-todo]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/duplicator.cc@106
PS2, Line 106:   // TODO deal queue data
> warning: missing username/bug in TODO [google-readability-todo]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h
File src/kudu/duplicator/kafka/kafka_connector.h:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@28
PS2, Line 28: #include <stdint.h>
> warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cst
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@69
PS2, Line 69: using std::map;
> warning: using decl 'map' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@70
PS2, Line 70: using std::string;
> warning: using declarations in the global namespace in headers are prohibit
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@140
PS2, Line 140:   virtual Status InitPrepare() override {
> warning: 'virtual' is redundant since the function is already declared 'ove
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@158
PS2, Line 158:   virtual Status Init() override {
> warning: 'virtual' is redundant since the function is already declared 'ove
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@209
PS2, Line 209:   virtual Status WriteBatch(
> warning: 'virtual' is redundant since the function is already declared 'ove
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@263
PS2, Line 263:   virtual Status TestBasicClientApi(const std::string& msg) override {
> warning: 'virtual' is redundant since the function is already declared 'ove
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.h@284
PS2, Line 284:   virtual ~KafkaConnector() {}
> warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc
File src/kudu/duplicator/kafka/kafka_connector.cc:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@20
PS2, Line 20: using cppkafka::Configuration;
> warning: using decl 'Configuration' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@21
PS2, Line 21: using cppkafka::Exception;
> warning: using decl 'Exception' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@22
PS2, Line 22: using cppkafka::MessageBuilder;
> warning: using decl 'MessageBuilder' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@23
PS2, Line 23: using cppkafka::Metadata;
> warning: using decl 'Metadata' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@24
PS2, Line 24: using cppkafka::Producer;
> warning: using decl 'Producer' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@26
PS2, Line 26: using std::make_shared;
> warning: using decl 'make_shared' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@27
PS2, Line 27: using std::shared_ptr;
> warning: using decl 'shared_ptr' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@29
PS2, Line 29: using std::vector;
> warning: using decl 'vector' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/kafka_connector.cc@30
PS2, Line 30: using strings::Substitute;
> warning: using decl 'Substitute' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/mock_kafka_connector.h
File src/kudu/duplicator/kafka/mock_kafka_connector.h:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/mock_kafka_connector.h@33
PS2, Line 33:   explicit MockProducer(const Configuration /* config */) : timeout_ms_(30000) {}
> warning: the const qualified parameter #1 is copied for each invocation; co
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/duplicator/kafka/mock_kafka_connector.h@68
PS2, Line 68:   void check_error(rd_kafka_resp_err_t error) {
> warning: method 'check_error' can be made static [readability-convert-membe
make it private.


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/integration-tests/duplication_with_kafka-itest.cc
File src/kudu/integration-tests/duplication_with_kafka-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/integration-tests/duplication_with_kafka-itest.cc@24
PS2, Line 24: #include <stdint.h>
> warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cst
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/integration-tests/duplication_with_kafka-itest.cc@25
PS2, Line 25: #include <stdlib.h>
> warning: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cst
Done


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/tablet/ops/op_driver.cc
File src/kudu/tablet/ops/op_driver.cc:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/tablet/ops/op_driver.cc@294
PS2, Line 294:     if (op_->type() == consensus::FOLLOWER) {
> warning: repeated branch in conditional chain [bugprone-branch-clone]
temp


http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/tablet/tablet_replica.h
File src/kudu/tablet/tablet_replica.h:

http://gerrit.cloudera.org:8080/#/c/18350/2/src/kudu/tablet/tablet_replica.h@514
PS2, Line 514:         const std::deque<std::shared_ptr<WriteOpState>> ops);
> warning: parameter 'ops' is const-qualified in the function declaration; co
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 03:34:57 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#6).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
66 files changed, 2,585 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#11).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
M build-support/jenkins/build-and-test.sh
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-proto/build.gradle
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
71 files changed, 2,617 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 11
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#2).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
A src/kudu/duplicator/kafka/mock_kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
67 files changed, 2,643 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18350 )

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................


Patch Set 5:

> Patch Set 4:
> 
> (1 comment)
done


-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 06:31:54 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#7).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
66 files changed, 2,594 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#12).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

The work is in progress, I hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator, it can be thinked as leader's shadows(now only one duplicator).
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator and duplicator replay wal thread pool, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests, Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-proto/build.gradle
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/consensus_meta_manager.cc
M src/kudu/consensus/consensus_meta_manager.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplication_replay-test.cc
A src/kudu/duplicator/duplication_replay.cc
A src/kudu/duplicator/duplication_replay.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
A src/kudu/duplicator/wal_file_reader.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/alter_schema_op.h
A src/kudu/tablet/ops/duplication_op.cc
A src/kudu/tablet/ops/duplication_op.h
M src/kudu/tablet/ops/op.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/op_driver.h
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/ops/op_tracker.cc
M src/kudu/tablet/ops/participant_op.h
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/tserver/tablet_server_runner.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/util/blocking_queue.h
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
93 files changed, 4,228 insertions(+), 161 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/12
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 12
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#9).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-proto/build.gradle
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/disk_failure-itest.cc
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
71 files changed, 2,615 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18350 )

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................


Patch Set 6:

(2 comments)

remove the file.

http://gerrit.cloudera.org:8080/#/c/18350/5/src/kudu/duplicator/kafka/mock_kafka_connector.h
File src/kudu/duplicator/kafka/mock_kafka_connector.h:

http://gerrit.cloudera.org:8080/#/c/18350/5/src/kudu/duplicator/kafka/mock_kafka_connector.h@43
PS5, Line 43: 
> warning: method 'produce' can be made static [readability-convert-member-fu
Done


http://gerrit.cloudera.org:8080/#/c/18350/5/src/kudu/duplicator/kafka/mock_kafka_connector.h@59
PS5, Line 59: 
> warning: method 'flush' can be made static [readability-convert-member-func
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 07:59:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has abandoned this change. ( http://gerrit.cloudera.org:8080/18350 )

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................


Abandoned

I abandon it. New patch is https://gerrit.cloudera.org/c/20151/
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 12
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#5).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
A src/kudu/duplicator/kafka/mock_kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
67 files changed, 2,639 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18350 )

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................


Patch Set 2:

(26 comments)

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/integration-tests/duplication_with_kafka-itest.cc
File src/kudu/integration-tests/duplication_with_kafka-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/integration-tests/duplication_with_kafka-itest.cc@115
PS1, Line 115:             LOG(INFO) << "kafka payload: " << msg.get_payload();
> warning: the 'empty' method should be used to check for emptiness instead o
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/integration-tests/duplication_with_kafka-itest.cc@147
PS1, Line 147:     // Print the assigned partitions on assignment
> warning: method 'DestroyKafka' can be made static [readability-convert-memb
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/integration-tests/duplication_with_kafka-itest.cc@208
PS1, Line 208:     bool is_altering = true;
> warning: parameter 'unused' is unused [misc-unused-parameters]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/integration-tests/duplication_with_kafka-itest.cc@254
PS1, Line 254:           errors.front()->status();
> warning: method 'SimpleKuduSchema' can be made static [readability-convert-
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/integration-tests/external_mini_cluster-itest-base.cc
File src/kudu/integration-tests/external_mini_cluster-itest-base.cc:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/integration-tests/external_mini_cluster-itest-base.cc@72
PS1, Line 72: }
> warning: 'opts' used after it was moved [bugprone-use-after-move]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/master/catalog_manager.cc@1997
PS1, Line 1997:   // TODO(duyuqi), remove the condition check
> warning: missing username/bug in TODO [google-readability-todo]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/master/catalog_manager.cc@3283
PS1, Line 3283:               }
> warning: do not use 'else' after 'break' [readability-else-after-return]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/master/catalog_manager.cc@4631
PS1, Line 4631:     }
> warning: Value stored to 'duplication_factor' is never read [clang-analyzer
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/rebalance/cluster_status.h
File src/kudu/rebalance/cluster_status.h:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/rebalance/cluster_status.h@82
PS1, Line 82:       term(term),
> warning: std::move of the variable 'term' of the trivially-copyable type 'b
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/rebalance/cluster_status.h@83
PS1, Line 83:       opid_index(opid_index),
> warning: std::move of the variable 'opid_index' of the trivially-copyable t
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/local_tablet_writer.h
File src/kudu/tablet/local_tablet_writer.h:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/local_tablet_writer.h@114
PS1, Line 114:     op_state_.reset(new WriteOpState(tablet_replica_ptr.get(), &req_, nullptr));
> warning: use nullptr [modernize-use-nullptr]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/ops/op_driver.cc
File src/kudu/tablet/ops/op_driver.cc:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/ops/op_driver.cc@294
PS1, Line 294:     if (op_->type() == consensus::FOLLOWER) {
> warning: repeated branch in conditional chain [bugprone-branch-clone]
temp


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/ops/op_driver.cc@527
PS1, Line 527:     {
> warning: missing username/bug in TODO [google-readability-todo]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/ops/write_op.cc
File src/kudu/tablet/ops/write_op.cc:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/ops/write_op.cc@277
PS1, Line 277:   RETURN_NOT_OK(state_ptr->tablet_replica()->tablet()->ApplyRowOperations(state_ptr));
> error: unexpected namespace name 'tablet': expected expression [clang-diagn
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet.h@192
PS1, Line 192:   Status ApplyRowOperations(const std::shared_ptr<WriteOpState>& op_state_ptr) WARN_UNUSED_RESULT;
> warning: non-const reference parameter 'op_state_ptr', make it const or use
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet.h@197
PS1, Line 197:                            const std::shared_ptr<WriteOpState>& op_state_ptr,
> warning: non-const reference parameter 'op_state_ptr', make it const or use
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_bootstrap.cc
File src/kudu/tablet/tablet_bootstrap.cc:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_bootstrap.cc@321
PS1, Line 321:                            const std::shared_ptr<WriteOpState>& op_state,
> warning: non-const reference parameter 'op_state', make it const or use a p
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_bootstrap.cc@341
PS1, Line 341:                          const std::shared_ptr<WriteOpState>& op_state,
> warning: non-const reference parameter 'op_state', make it const or use a p
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.h
File src/kudu/tablet/tablet_replica.h:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.h@429
PS1, Line 429:     return duplicator_->last_confirmed_opid();
> warning: return type 'const consensus::OpId' is 'const'-qualified at the to
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.h@433
PS1, Line 433:   void set_last_committed_opid(const consensus::OpId& last_committed_opid) {
> warning: parameter 'last_committed_opid' is passed by value and only copied
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.h@435
PS1, Line 435:   }
> warning: return type 'const consensus::OpId' is 'const'-qualified at the to
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.h@548
PS1, Line 548:   };
> warning: annotate this function with 'override' or (rarely) 'final' [modern
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.cc@231
PS1, Line 231:     // Init a ThreadPoolToken for the TabletReplica
> warning: 'server_ctx' used after it was moved [bugprone-use-after-move]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.cc@251
PS1, Line 251:     DnsResolver* resolver) {
> warning: parameter 'duplicate_pool' is unused [misc-unused-parameters]
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tablet/tablet_replica.cc@1389
PS1, Line 1389:     const deque<std::shared_ptr<WriteOpState>> ops) {
> warning: the parameter 'ops' is copied for each invocation but only used as
Done


http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tools/ksck.h
File src/kudu/tools/ksck.h:

http://gerrit.cloudera.org:8080/#/c/18350/1/src/kudu/tools/ksck.h@81
PS1, Line 81:   // TODO(duyuqi), In fact, !is_voter stable is duplicator, but
> warning: missing username/bug in TODO [google-readability-todo]
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 24 Mar 2022 15:06:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#4).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
A src/kudu/duplicator/kafka/mock_kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
67 files changed, 2,639 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] WIP KUDU-3290 support duplication to kafka

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18350

to look at the new patch set (#8).

Change subject: WIP KUDU-3290 support duplication to kafka
......................................................................

WIP KUDU-3290 support duplication to kafka

Although the work is in progress, I also hope someone
can review the scheme, and welcome your advisors.

Maybe new thirdparty deps: librdkafka, cppkafka lead to compile failed.

The issue: https://issues.apache.org/jira/browse/KUDU-3290
Design document: https://docs.google.com/document/d/1ihqPFO1vulpYDYYKcHmhes0LCOXKQtdAf5ub0y2LiaM/edit?usp=sharing

Add a new MemberType: Duplicator.
Add thirdparty for librdkafka and cppkafka.
Add thread pool for duplicator, add kafka client for duplication.
Support create table with duplictor, java and cpp
Support alter table for enable/disable duplication, java and cpp
Fix unit tests and add unit tests,
Add itest for duplicate to kafka,
Support kerberos for kafka client

Conflicts:
	src/kudu/tablet/ops/write_op.cc

Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
---
M CMakeLists.txt
A cmake_modules/FindCppKafka.cmake
A cmake_modules/FindRdKafka.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-proto/build.gradle
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/replica_controller-internal.cc
M src/kudu/client/replica_controller-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/quorum_util.h
M src/kudu/consensus/raft_consensus.h
A src/kudu/duplicator/CMakeLists.txt
A src/kudu/duplicator/connector.h
A src/kudu/duplicator/duplicator.cc
A src/kudu/duplicator/duplicator.h
A src/kudu/duplicator/kafka/kafka.proto
A src/kudu/duplicator/kafka/kafka_connector-test.cc
A src/kudu/duplicator/kafka/kafka_connector.cc
A src/kudu/duplicator/kafka/kafka_connector.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/duplication_with_kafka-itest.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rebalance/cluster_status.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/tool_action_perf.cc
M src/kudu/transactions/txn_status_tablet.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/kafka-simple-control.sh
M thirdparty/vars.sh
67 files changed, 2,595 insertions(+), 80 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/18350/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018
Gerrit-Change-Number: 18350
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>