You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Ard Schrijvers (JIRA)" <ji...@apache.org> on 2006/06/21 10:54:29 UTC

[jira] Created: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
--------------------------------------------------------------------------------------------------------------

         Key: COCOON-1868
         URL: http://issues.apache.org/jira/browse/COCOON-1868
     Project: Cocoon
        Type: Bug

  Components: * Cocoon Core  
    Versions: 2.1.8    
    Reporter: Ard Schrijvers
    Priority: Minor


When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 

Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Ard Schrijvers (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1868?page=all ]

Ard Schrijvers updated COCOON-1868:
-----------------------------------

    Attachment: EHDefaultStore.patch

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Priority: Minor
>  Attachments: EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Ard Schrijvers (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1868?page=comments#action_12417268 ] 

Ard Schrijvers commented on COCOON-1868:
----------------------------------------

You can only reproduce the bug, when there is actually at least one thing in the EHDefaultStore, so starting cocoon and immediately shutting it down does not reproduce the bug. 

What I though just tested, is trying it with ehcache 1.2. Indeed, it seems to added to ehcache 1.2 that when overflow-to-disk is set to false, it does not try to spoolToDisk on a shut down when diskPersistent is true. With ehcache 1.1, this was probably not tested, resulting in the spoolToDisk error. 

So, the bug was fixed with ehcache 1.2. Though adding the diskpersistent parameter still adds functionality: If you want the number of cachekeys  to be able to grow beyond the number defined in maxobjects, you define "overflow-to-disk"=true. Then by default, when "diskpersitent" is not defined, on a JVM shutdown, the part of the cache in memory is spooled to disk. 
Though, you might want to have a not diskPersistent cache (for example during development you perhaps dont want the cache stored on disk when JVM shuts down and the cache gets populated on a restart). With the patch, you are able (not obliged) to define how you want your ehcache to behave.

I must though admit that with ehcache 1.2, since the bug is solved, only some marginal functionality is added by this patch :-) 

COCOON-1694 was another fix, that is uncorrelated to the part I did. It was about the StoreJanitor disposing all its caches on a cocoon shutdown. It did not check wether the cache was still alive (it could have been stopped by another process). So, before cacheManager.shutdown() is called, a check wether the cache is still alive is done. 

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>  Attachments: EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1868?page=comments#action_12417269 ] 

Antonio Gallardo commented on COCOON-1868:
------------------------------------------

I did not test in cocoon 2.1.8. I tested directly in cocoon 2.1.10-dev. Of course, while testing I also opened some pages in order to add some entries to the cache. I am glad the bug is already fixed in our trunk just by upgrading to ehcache 1.2. I agree this add functionality, but IMHO it must be refactored since in the patch "diskPersistent" depends on "overflow-to-disk"=true and the ehcache docs states this parameters are independent of each other.

WDYT?

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>  Attachments: EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Ard Schrijvers (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1868?page=all ]

Ard Schrijvers updated COCOON-1868:
-----------------------------------

    Attachment: EHDefaultStore-2.patch

This is the patched to be used: dependency between overflow-to-disk and diskpersistent is removed

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>  Attachments: EHDefaultStore-2.patch, EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1868?page=comments#action_12417249 ] 

Antonio Gallardo commented on COCOON-1868:
------------------------------------------

BTW, Recently was closed COCOON-1694 wich is about ehcache shutdown. Would you review it?

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>  Attachments: EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1868?page=comments#action_12417248 ] 

Antonio Gallardo commented on COCOON-1868:
------------------------------------------

I set overflow-to-disk=false and I can start and stop the cocoon without seeing and error. I am sorry, but I was unable to reproduce this bug in the current trunk. Would you describe me what I can do to see this bug in action? Please note we have ehcache 1.2 in our current trunk.

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>  Attachments: EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Ard Schrijvers (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1868?page=comments#action_12417272 ] 

Ard Schrijvers commented on COCOON-1868:
----------------------------------------

You have indeed a good point. With ehcache 1.1 I assumed dependency between the two parameters because of the spoolToDisk error, but with ehcache 1.2, this dependency is indeed not there anymore. I will remove the dependency and add another patch having the two parameters independent. I think diskPersistent=true by default, right?

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>  Attachments: EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1868?page=all ]

Antonio Gallardo reassigned COCOON-1868:
----------------------------------------

    Assign To: Antonio Gallardo

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>  Attachments: EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (COCOON-1868) When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1868?page=all ]
     
Antonio Gallardo closed COCOON-1868:
------------------------------------

    Fix Version: 2.2-dev (Current SVN)
                 2.1.10-dev (current SVN)
     Resolution: Fixed

This bug was fixed by updating ehcache to 1.2. The patch was applied because it allows to configure a disk-persistent ehcache property.

> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error
> --------------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1868
>          URL: http://issues.apache.org/jira/browse/COCOON-1868
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8
>     Reporter: Ard Schrijvers
>     Assignee: Antonio Gallardo
>     Priority: Minor
>      Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>  Attachments: EHDefaultStore-2.patch, EHDefaultStore.patch
>
> When using EHDefaultStore in overflow-to-disk=false mode, shutting the jvm down results in a spoolToDisk error. This is because diskPersistent is not Parameterizable and always TRUE. However, when overflow-to-disk is false (caching in memory only), when shutting the JVM down, ehcache is trying to flush the cache to disk because diskPersistent is true. 
> Added diskPersistent parameter, which is FALSE when overflow-to-disk is false, and default TRUE when overflow-to-disk is TRUE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira