[GitHub] [flink] dannycranmer commented on a change in pull request #18606: [FLINK-25924][connectors/firehose] Adding a timeout for the Localstac…

[GitBox <gi...@apache.org>]

dannycranmer commented on a change in pull request #18606:
URL: https://github.com/apache/flink/pull/18606#discussion_r797607914



##########
File path: flink-connectors/flink-connector-aws-base/src/test/java/org/apache/flink/connector/aws/testutils/LocalstackContainer.java
##########
@@ -61,6 +61,11 @@ public String getEndpoint() {
 
         @Override
         protected void waitUntilReady() {
+            try {
+                Thread.sleep(10000);
+            } catch (InterruptedException e) {
+                e.printStackTrace();

Review comment:
       Understand this is the same as the KDS one, but if we are interrupted should probably exit. Instead of just printing can we rethrow? Worth updating the KDS one too 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org