You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2026/09/15 12:25:59 UTC
[PR] Fix flaky IoTDBAutoRegionGroupExtension2IT during DataNode shutdown [iotdb]
CRZbulabula opened a new pull request, #18642:
URL: https://github.com/apache/iotdb/pull/18642
## Description
`IoTDBAutoRegionGroupExtension2IT` verifies that DataRegionGroups can still be extended while one DataNode is unavailable.
The test currently stops a DataNode gracefully and waits until the ConfigNode reports it as `Unknown`. During graceful shutdown, however, the DataNode temporarily changes its status to `ReadOnly`. An in-flight heartbeat sampled during this window may update the ConfigNode after the test has already observed the `Unknown` status.
When this happens, `RegionBalancer` excludes the `ReadOnly` DataNode and sees only two available candidates for a replication factor of three. The partition request then returns `NO_ENOUGH_DATANODE (1003)` instead of `SUCCESS_STATUS`, making the test fail intermittently.
## Changes
- Stop the unavailable DataNode forcibly in `IoTDBAutoRegionGroupExtension2IT`.
- Continue waiting for the ConfigNode to observe the DataNode as `Unknown` before creating partitions.
A forced stop matches the unavailable-node scenario that this test is intended to cover and avoids the transient `ReadOnly` state introduced by graceful shutdown. This change does not modify production node-status or allocation semantics.
## Tests
```shell
mvn clean verify \
-DskipUTs \
-Dit.test=IoTDBAutoRegionGroupExtension2IT \
-DfailIfNoTests=false \
-Dfailsafe.failIfNoSpecifiedTests=false \
-pl integration-test -am \
-PClusterIT \
-P with-integration-tests
```
Result: 1 test run, 0 failures, 0 errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky IoTDBAutoRegionGroupExtension2IT during DataNode shutdown [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula merged PR #18642:
URL: https://github.com/apache/iotdb/pull/18642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org