[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #10093: [improvement](profile) Add table name and predicates

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #10093:
URL: https://github.com/apache/incubator-doris/pull/10093#discussion_r896371963


##########
be/src/exec/olap_scan_node.cpp:
##########
@@ -653,6 +656,30 @@ Status OlapScanNode::normalize_conjuncts() {
     return Status::OK();
 }
 
+static std::string olap_filter_to_string(const doris::TCondition& condition) {
+    std::stringstream ss;

Review Comment:
   better use `format` to do thing of format output. `std::stringstream` have performance problem in multi thread



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org