You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/15 13:05:20 UTC
[GitHub] [ratis-thirdparty] codings-dan opened a new pull request, #38: Revert "RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty. (#34)"
codings-dan opened a new pull request, #38:
URL: https://github.com/apache/ratis-thirdparty/pull/38
This reverts commit 722c122d777e2b3e6a05e69afe59aa9f5a490bd3.
Due to compatibility issues, we need to revert RATIS-1595 before releasing 1.0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] codings-dan commented on pull request #38: RATIS-1672. Revert "RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty. (#34)"
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #38:
URL: https://github.com/apache/ratis-thirdparty/pull/38#issuecomment-1216577994
@szetszwo Thanks for the review, RATIS-1595 really doesn't need revert, let me close this pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] codings-dan closed pull request #38: RATIS-1672. Revert "RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty. (#34)"
Posted by GitBox <gi...@apache.org>.
codings-dan closed pull request #38: RATIS-1672. Revert "RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty. (#34)"
URL: https://github.com/apache/ratis-thirdparty/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] codings-dan commented on pull request #38: RATIS-1672. Revert "RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty. (#34)"
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #38:
URL: https://github.com/apache/ratis-thirdparty/pull/38#issuecomment-1214993784
@szetszwo Could you help take a look at this pull request, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo commented on pull request #38: RATIS-1672. Revert "RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty. (#34)"
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #38:
URL: https://github.com/apache/ratis-thirdparty/pull/38#issuecomment-1215270186
@codings-dan , we should revert RATIS-1601 and then RATIS-1391 from the master branch. RATIS-1595 in the thirdparty branch is okay since shading itself isn't incompatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org