You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@abrahamfine.com> on 2016/02/01 22:58:26 UTC

Re: Review Request 42951: SQOOP-2808

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42951/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 9:58 p.m.)


Review request for Sqoop.


Bugs: sqoop-2808
    https://issues.apache.org/jira/browse/sqoop-2808


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Integration tests should test rows with null values


Diffs (updated)
-----

  common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 4e1ef6a2586ab7cf0582b42e7fe6a6d6b3fd5d50 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 7c943c2b44f444f8b8eab914acd2f312fedeeef8 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java b430739a4ec9ea21ffbd913b544902a7c76a1161 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 774221aaf5c8cdb8d26ca108fae239598b42229b 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java 7d2177fd89735b80e43d26d4ff9d89bf3cab64aa 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 11fcef2a38209c79928f582cf8aa03e889247f22 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 9b0885ada3a914719aeaa70417bca7f41e71257f 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java d78fa8b72ecfe62eeec240e01597e7f2a7e4dd76 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 8db4d3da2eae33772f6f3c82ce0a1f2f2127ae02 
  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java 703ed0a071afe055ed5ad953ed47987ea96468b7 
  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 040dbfcc9a8b6fea75e4e5f263cf125b123b00b2 
  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java bcc1f95911aa7c51fad9bb902264ca610e3bd0e3 
  test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/42951/diff/


Testing
-------

yes


Thanks,

Abraham Fine

Re: Review Request 42951: SQOOP-2808

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42951/#review117410
-----------------------------------------------------------


Ship it!




Ship It!

- Jarek Cecho


On Feb. 1, 2016, 9:58 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42951/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 9:58 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: sqoop-2808
>     https://issues.apache.org/jira/browse/sqoop-2808
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Integration tests should test rows with null values
> 
> 
> Diffs
> -----
> 
>   common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 4e1ef6a2586ab7cf0582b42e7fe6a6d6b3fd5d50 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 7c943c2b44f444f8b8eab914acd2f312fedeeef8 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java b430739a4ec9ea21ffbd913b544902a7c76a1161 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 774221aaf5c8cdb8d26ca108fae239598b42229b 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java 7d2177fd89735b80e43d26d4ff9d89bf3cab64aa 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 11fcef2a38209c79928f582cf8aa03e889247f22 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 9b0885ada3a914719aeaa70417bca7f41e71257f 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java d78fa8b72ecfe62eeec240e01597e7f2a7e4dd76 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 8db4d3da2eae33772f6f3c82ce0a1f2f2127ae02 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java 703ed0a071afe055ed5ad953ed47987ea96468b7 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 040dbfcc9a8b6fea75e4e5f263cf125b123b00b2 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java bcc1f95911aa7c51fad9bb902264ca610e3bd0e3 
>   test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42951/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>