You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "youngxhui (via GitHub)" <gi...@apache.org> on 2025/08/24 03:13:40 UTC
[PR] Support Gozero [skywalking-go]
youngxhui opened a new pull request, #230:
URL: https://github.com/apache/skywalking-go/pull/230
Support [Gozero](https://github.com/zeromicro/go-zero) framework
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Gozero [skywalking-go]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #230:
URL: https://github.com/apache/skywalking-go/pull/230#issuecomment-3223294793
It will merge the main branch into your branch, so it's fine to run this. You should focus on the CI issue, rather than the commit ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Gozero [skywalking-go]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #230:
URL: https://github.com/apache/skywalking-go/pull/230#discussion_r2300338347
##########
go.mod:
##########
@@ -5,16 +5,19 @@ go 1.19
require (
github.com/google/uuid v1.3.0
github.com/pkg/errors v0.9.1
+ github.com/segmentio/kafka-go v0.4.48
Review Comment:
`go mod tidy` is use for the single module, in the go work concept, you should use `go work sync`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Gozero [skywalking-go]
Posted by "youngxhui (via GitHub)" <gi...@apache.org>.
youngxhui commented on PR #230:
URL: https://github.com/apache/skywalking-go/pull/230#issuecomment-3222176419
Why does this commit hash appear to be wrong? My last commit ID is 3012842, but the CI build is using 4b51072. I expected the CI to build the latest commit, so I’m trying to understand why it’s picking an error one. @mrproliu thanks.
`CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -ldflags "-X main.version=4b51072 -X main.gitCommit=4b51072" -o /home/runner/work/skywalking-go/skywalking-go/tools/go-agent/../..//bin/skywalking-go-agent-4b51072-linux-amd64 ./cmd`
https://github.com/apache/skywalking-go/actions/runs/17224357417/job/48866299992?pr=230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Gozero [skywalking-go]
Posted by "youngxhui (via GitHub)" <gi...@apache.org>.
youngxhui commented on code in PR #230:
URL: https://github.com/apache/skywalking-go/pull/230#discussion_r2299427554
##########
go.mod:
##########
@@ -5,16 +5,19 @@ go 1.19
require (
github.com/google/uuid v1.3.0
github.com/pkg/errors v0.9.1
+ github.com/segmentio/kafka-go v0.4.48
Review Comment:
When I run go mod tidy, Kafka is automatically added to go.mod. Using go mod why, I found that it is being used in the reporter.
```sh
go mod why -m github.com/segmentio/kafka-go
# github.com/segmentio/kafka-go
github.com/apache/skywalking-go/agent/reporter
github.com/segmentio/kafka-go
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Gozero [skywalking-go]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #230:
URL: https://github.com/apache/skywalking-go/pull/230#issuecomment-3217693763
Please fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Gozero [skywalking-go]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #230:
URL: https://github.com/apache/skywalking-go/pull/230#discussion_r2296495955
##########
plugins/gozero/go.mod:
##########
@@ -0,0 +1,93 @@
+module github.com/apache/skywalking-go/plugins/gozero
+
+go 1.19
+
+
+require (
+ github.com/apache/skywalking-go/plugins/core v0.0.0-20250718051351-654a5930e77d
Review Comment:
You have already using the workspace, why still need to import this?
##########
go.mod:
##########
@@ -5,16 +5,19 @@ go 1.19
require (
github.com/google/uuid v1.3.0
github.com/pkg/errors v0.9.1
+ github.com/segmentio/kafka-go v0.4.48
Review Comment:
Why there have dependency changes?
##########
plugins/gozero/rest/server_middleware_intercepter.go:
##########
@@ -0,0 +1,105 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package rest
+
+import (
+ "fmt"
+ "net/http"
+
+ "github.com/apache/skywalking-go/plugins/core/operator"
+ "github.com/apache/skywalking-go/plugins/core/tracing"
+ "github.com/zeromicro/go-zero/rest"
+)
+
+const gozeroComponent int32 = 5023
+
+type ServerMiddlewareInterceptor struct {
+}
+
+// SkyWalking middleware - 采用 go-micro 的策略：复用底层 span 而不是与其冲突
Review Comment:
Please don't add the Chinese comment in every files.
##########
go.work:
##########
@@ -2,78 +2,80 @@ go 1.19
use (
.
+ ./plugins/amqp
// define the plugins
./plugins/core
./plugins/dubbo
+ ./plugins/echov4
Review Comment:
Please don't change the original workspace, just add your project into the correct place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Gozero [skywalking-go]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #230: Support Gozero
URL: https://github.com/apache/skywalking-go/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org