[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2868: ARTEMIS-2466 PageSyncTimer::timeSync isn't configurable using ASYNCIO

[GitBox <gi...@apache.org>]

wy96f commented on a change in pull request #2868: ARTEMIS-2466 PageSyncTimer::timeSync isn't configurable using ASYNCIO
URL: https://github.com/apache/activemq-artemis/pull/2868#discussion_r338436542
 
 

 ##########
 File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
 ##########
 @@ -1002,43 +1003,51 @@ private void applyAddressesAndQueues(HashMap<String, String> filters) {
    private void performAutoTune(HashMap<String, String> filters, JournalType journalType, File dataFolder) {
       if (noAutoTune) {
          filters.put("${journal-buffer.settings}", "");
+         filters.put("${page-sync.settings}", "");
       } else {
          try {
             int writes = 250;
             System.out.println("");
             System.out.println("Auto tuning journal ...");
 
+            long time = SyncCalculation.syncTest(dataFolder, 4096, writes, 5, verbose, !noJournalSync, false, "journal-test.tmp", ActiveMQDefaultConfiguration.getDefaultJournalMaxIoAio(), journalType);
+            long nanoseconds = SyncCalculation.toNanos(time, writes, verbose);
+            double writesPerMillisecond = (double) writes / (double) time;
+            String writesPerMillisecondStr = new DecimalFormat("###.##").format(writesPerMillisecond);
 
 Review comment:
   If AIO or MAPPED, we should run another test using `NIOSequentialFile` to apply to page-sync-timeout.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services