You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/08/26 21:03:59 UTC
[jira] Created: (CASSANDRA-393) rename storageendpoint overloads
for clarity
rename storageendpoint overloads for clarity
--------------------------------------------
Key: CASSANDRA-393
URL: https://issues.apache.org/jira/browse/CASSANDRA-393
Project: Cassandra
Issue Type: Task
Reporter: Jonathan Ellis
Priority: Minor
StorageService:
getNLiveStorageEndPoint(String):List<EndPoint>
getNStorageEndPoint(String):EndPoint[]
getNStorageEndPoint(Token):EndPoint[]
getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
getNStorageEndPoints(String[]):Map<String, EndPoint[]>
some of these should get getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-393:
-------------------------------------
Attachment: 0003-rename-remaining-methods.txt
0002-r-m-LoadVerbHandler-and-unused-endpoint-related-code.txt
0001-CASSANDRA-393-r-m-unnecessary-IReplicationStrategy-int.txt
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-393-r-m-unnecessary-IReplicationStrategy-int.txt, 0002-r-m-LoadVerbHandler-and-unused-endpoint-related-code.txt, 0003-rename-remaining-methods.txt
>
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748166#action_12748166 ]
Sandeep Tata commented on CASSANDRA-393:
----------------------------------------
+1, makes good sense.
The maps actually get Hinted and that should be reflected in the name.
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Reporter: Jonathan Ellis
> Priority: Minor
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749881#action_12749881 ]
Hudson commented on CASSANDRA-393:
----------------------------------
Integrated in Cassandra #184 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/184/])
r/m unnecessary IReplicationStrategy interface. r/m LoadVerbHandler and unused endpoint-related code. rename AbstractStrategy -> AbstractReplicationStrategy and getEndpoint methods.
patch by jbellis; reviewed by Sandeep Tata for
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-393-r-m-unnecessary-IReplicationStrategy-int.txt, 0002-r-m-LoadVerbHandler-and-unused-endpoint-related-code.txt, 0003-rename-remaining-methods.txt
>
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-393:
-------------------------------------
Component/s: Core
Fix Version/s: 0.4
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.4
>
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749044#action_12749044 ]
Sandeep Tata commented on CASSANDRA-393:
----------------------------------------
+1
There's an unused HashMap import in RackUnaware and RackAware Strategies we could get rid of.
Otherwise, it looks good, unit tests pass, nosetests pass.
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-393-r-m-unnecessary-IReplicationStrategy-int.txt, 0002-r-m-LoadVerbHandler-and-unused-endpoint-related-code.txt, 0003-rename-remaining-methods.txt
>
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-393:
----------------------------------------
Assignee: Jonathan Ellis
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.4
>
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748920#action_12748920 ]
Jonathan Ellis commented on CASSANDRA-393:
------------------------------------------
03
rename remaining StorageService methods
02
r/m LoadVerbHandler and unused endpoint-related code
01
CASSANDRA-393 r/m unnecessary IReplicationStrategy interface. rename AbstractStrategy -> AbstractReplicationStrategy. rename endpoint methods in ARS.
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-393-r-m-unnecessary-IReplicationStrategy-int.txt, 0002-r-m-LoadVerbHandler-and-unused-endpoint-related-code.txt, 0003-rename-remaining-methods.txt
>
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-393) rename storageendpoint overloads
for clarity
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-393:
-------------------------------------
Description:
StorageService:
getNLiveStorageEndPoint(String):List<EndPoint>
getNStorageEndPoint(String):EndPoint[]
getNStorageEndPoint(Token):EndPoint[]
getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
getNStorageEndPoints(String[]):Map<String, EndPoint[]>
some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
was:
StorageService:
getNLiveStorageEndPoint(String):List<EndPoint>
getNStorageEndPoint(String):EndPoint[]
getNStorageEndPoint(Token):EndPoint[]
getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
getNStorageEndPoints(String[]):Map<String, EndPoint[]>
some of these should get getWriteSEP. Some getHintedSEP. Some getReadSEP.
> rename storageendpoint overloads for clarity
> --------------------------------------------
>
> Key: CASSANDRA-393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-393
> Project: Cassandra
> Issue Type: Task
> Reporter: Jonathan Ellis
> Priority: Minor
>
> StorageService:
> getNLiveStorageEndPoint(String):List<EndPoint>
> getNStorageEndPoint(String):EndPoint[]
> getNStorageEndPoint(Token):EndPoint[]
> getNStorageEndPoint(Token, Map<Token, EndPoint>):EndPoint[]
> getNStorageEndPointMap(String):Map<EndPoint, EndPoint>
> getNStorageEndPoints(String[]):Map<String, EndPoint[]>
> some of these should be getWriteSEP. Some getHintedSEP. Some getReadSEP.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.