You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by christophse <gi...@git.apache.org> on 2016/10/29 15:49:24 UTC
[GitHub] incubator-gearpump pull request #103: Removed unused code from AppMasterServ...
GitHub user christophse opened a pull request:
https://github.com/apache/incubator-gearpump/pull/103
Removed unused code from AppMasterService.
Hello,
Seems there is some unused code in AppMasterService. This pull request removes it.
Regards
Christoph
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/christophse/incubator-gearpump fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit d30da6bd4ea5959e17a3c75f4c74acc60f38eff6
Author: Christoph Seifert <ch...@googlemail.com>
Date: 2016-10-29T15:36:03Z
Removed unused code from AppMasterService.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #103: [GEARPUMP-230] Removed unused code from AppMa...
Posted by christophse <gi...@git.apache.org>.
Github user christophse commented on the issue:
https://github.com/apache/incubator-gearpump/pull/103
@manuzhang, is there something more to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #103: [GEARPUMP-230] Removed unused code from AppMa...
Posted by christophse <gi...@git.apache.org>.
Github user christophse commented on the issue:
https://github.com/apache/incubator-gearpump/pull/103
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #103: Removed unused code from AppMasterService.
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/103
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/103?src=pr) is 72.26% (diff: 100%)
> Merging [#103](https://codecov.io/gh/apache/incubator-gearpump/pull/103?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **0.58%**
```diff
@@ master #103 diff @@
==========================================
Files 186 186
Lines 5985 5981 -4
Methods 5456 5456
Messages 0 0
Branches 529 525 -4
==========================================
+ Hits 4290 4322 +32
+ Misses 1695 1659 -36
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [fb37ce8...d30da6b](https://codecov.io/gh/apache/incubator-gearpump/compare/fb37ce809b2917a12cc64d4337418cbb72265fda...d30da6bd4ea5959e17a3c75f4c74acc60f38eff6?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #103: [GEARPUMP-230] Removed unused code from AppMa...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/103
Looks good, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #103: Removed unused code from AppMasterService.
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/103
@christophse thanks for your contribution. Can you open a jira at https://issues.apache.org/jira/browse/GEARPUMP and change the commit comments to "[GEARPUMP-XXX] Removed unused code from AppMasterService" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #103: [GEARPUMP-230] Removed unused code fro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---