You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "G Todd (JIRA)" <ji...@apache.org> on 2011/04/13 22:04:05 UTC

[jira] [Created] (TS-737) Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD

Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD
------------------------------------------------------------------------------------

                 Key: TS-737
                 URL: https://issues.apache.org/jira/browse/TS-737
             Project: Traffic Server
          Issue Type: Improvement
          Components: Build, Packaging, Portability
    Affects Versions: 2.1.8
         Environment: Running Revision: 1091892 on FreeBSD localhost 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
            Reporter: G Todd
            Priority: Minor
             Fix For: 2.1.8


The control script at rc/trafficserver needs to be hooked up to run on FreeBSD to avoid the "needs to be ported to this OS" message. I have changed script somewhat hackishly to achieve this.  

I have prepared a patch to rc/trafficserver.in that creates the proper rc/trafficserver script from a "make" run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TS-737) Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD

Posted by "G Todd (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

G Todd updated TS-737:
----------------------

    Attachment: trafficserver

This is a more elaborate "native" FreeBSD rc.d script than that currently included in the FreeBSD port (which is based on ATS 2.1.5).  I'm not up to speed regarding ATS project policies but this particular attachment is not really intended for inclusion in an ATS release since it is platform specific (though I suppose it could be included since releases do include solaris specific SMF manifests). 

Since FreeBSD's ports system manages the creation of FreeBSD specific rc.d scripts, patches to the upstream project source code, and installation of binaries, I'm including this modified script for reference and comments only. It should be copied to:

/usr/local/etc/rc.d/trafficserver 

and /etc/rc.conf modified appropriately.

NB: the script uses traffic_cop instead of launching traffic_server directly as per the current FreeBSD port. It also uses traffic_line for controlling the traffic_server process. This is similar to the ejabberd rc.d script's use of ejabberctl.


> Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD
> ------------------------------------------------------------------------------------
>
>                 Key: TS-737
>                 URL: https://issues.apache.org/jira/browse/TS-737
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build, Packaging, Portability
>    Affects Versions: 2.1.8
>         Environment: Running Revision: 1091892 on FreeBSD localhost 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>            Reporter: G Todd
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.1.8
>
>         Attachments: trafficserver, trafficserver.in-freebsd-patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The control script at rc/trafficserver needs to be hooked up to run on FreeBSD to avoid the "needs to be ported to this OS" message. I have changed script somewhat hackishly to achieve this.  
> I have prepared a patch to rc/trafficserver.in that creates the proper rc/trafficserver script from a "make" run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TS-737) Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD

Posted by "G Todd (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

G Todd updated TS-737:
----------------------

    Issue Type: Bug  (was: Improvement)

> Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD
> ------------------------------------------------------------------------------------
>
>                 Key: TS-737
>                 URL: https://issues.apache.org/jira/browse/TS-737
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build, Packaging, Portability
>    Affects Versions: 2.1.8
>         Environment: Running Revision: 1091892 on FreeBSD localhost 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>            Reporter: G Todd
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.1.8
>
>         Attachments: trafficserver, trafficserver.in-freebsd-patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The control script at rc/trafficserver needs to be hooked up to run on FreeBSD to avoid the "needs to be ported to this OS" message. I have changed script somewhat hackishly to achieve this.  
> I have prepared a patch to rc/trafficserver.in that creates the proper rc/trafficserver script from a "make" run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (TS-737) Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom reassigned TS-737:
--------------------------------

    Assignee: Leif Hedstrom

> Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD
> ------------------------------------------------------------------------------------
>
>                 Key: TS-737
>                 URL: https://issues.apache.org/jira/browse/TS-737
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build, Packaging, Portability
>    Affects Versions: 2.1.8
>         Environment: Running Revision: 1091892 on FreeBSD localhost 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>            Reporter: G Todd
>            Assignee: Leif Hedstrom
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.1.8
>
>         Attachments: trafficserver, trafficserver.in-freebsd-patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The control script at rc/trafficserver needs to be hooked up to run on FreeBSD to avoid the "needs to be ported to this OS" message. I have changed script somewhat hackishly to achieve this.  
> I have prepared a patch to rc/trafficserver.in that creates the proper rc/trafficserver script from a "make" run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TS-737) Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD

Posted by "G Todd (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

G Todd updated TS-737:
----------------------

    Attachment: trafficserver.in-freebsd-patch

Patch to trafficserver.in to build a working rc/trafficserver script for FreeBSD.

NB: These lines are needed if the script is not chmod'ed +x
+        sh $0 'stop'
+        sh $0 'start'



> Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD
> ------------------------------------------------------------------------------------
>
>                 Key: TS-737
>                 URL: https://issues.apache.org/jira/browse/TS-737
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build, Packaging, Portability
>    Affects Versions: 2.1.8
>         Environment: Running Revision: 1091892 on FreeBSD localhost 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>            Reporter: G Todd
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.1.8
>
>         Attachments: trafficserver.in-freebsd-patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The control script at rc/trafficserver needs to be hooked up to run on FreeBSD to avoid the "needs to be ported to this OS" message. I have changed script somewhat hackishly to achieve this.  
> I have prepared a patch to rc/trafficserver.in that creates the proper rc/trafficserver script from a "make" run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-737) Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD

Posted by "G Todd (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019826#comment-13019826 ] 

G Todd commented on TS-737:
---------------------------

Oops. There is now a comment regarding the "native" run script that is installed by the FreeBSD ports system in the script source. The comment is also echo'ed to stdout. That might be a bit superfluous. My bad.



> Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD
> ------------------------------------------------------------------------------------
>
>                 Key: TS-737
>                 URL: https://issues.apache.org/jira/browse/TS-737
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build, Packaging, Portability
>    Affects Versions: 2.1.8
>         Environment: Running Revision: 1091892 on FreeBSD localhost 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>            Reporter: G Todd
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.1.8
>
>         Attachments: trafficserver.in-freebsd-patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The control script at rc/trafficserver needs to be hooked up to run on FreeBSD to avoid the "needs to be ported to this OS" message. I have changed script somewhat hackishly to achieve this.  
> I have prepared a patch to rc/trafficserver.in that creates the proper rc/trafficserver script from a "make" run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-737) Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD

Posted by "G Todd (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019881#comment-13019881 ] 

G Todd commented on TS-737:
---------------------------

NB: I have tested the trafficserver.in-freebsd-patch to rc/trafficserver.in on Fedora and everything builds properly.  The modified rc/trafficserver behaves the same on Fedora as the unpatched version. i.e. there are some bothersome bits that come with killproc (it reports "Stopping traffic_cop: [ OK ]" even if there was no process running) but those are Fedora issues and they have not been impacted by the trafficserver.in-freebsd-patch attached to this issue.

Since rc/trafficserver already does some work to determine on which platform it is running, this patch can be safely applied to rc/trafficserver.in in order to unbreak and fix FreeBSD support in the script.


> Small hackish fix for rc/trafficserver.in so rc/trafficserver will work with FreeBSD
> ------------------------------------------------------------------------------------
>
>                 Key: TS-737
>                 URL: https://issues.apache.org/jira/browse/TS-737
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build, Packaging, Portability
>    Affects Versions: 2.1.8
>         Environment: Running Revision: 1091892 on FreeBSD localhost 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>            Reporter: G Todd
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.1.8
>
>         Attachments: trafficserver, trafficserver.in-freebsd-patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The control script at rc/trafficserver needs to be hooked up to run on FreeBSD to avoid the "needs to be ported to this OS" message. I have changed script somewhat hackishly to achieve this.  
> I have prepared a patch to rc/trafficserver.in that creates the proper rc/trafficserver script from a "make" run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira