You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "CalvinConfluent (via GitHub)" <gi...@apache.org> on 2025/01/29 00:24:08 UTC
[PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
CalvinConfluent opened a new pull request, #18733:
URL: https://github.com/apache/kafka/pull/18733
https://issues.apache.org/jira/browse/KAFKA-18662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
Posted by "CalvinConfluent (via GitHub)" <gi...@apache.org>.
CalvinConfluent commented on PR #18733:
URL: https://github.com/apache/kafka/pull/18733#issuecomment-2622200375
testAdminClientApisAuthenticationFailure and testWakeupAfterSyncGroupReceivedExternalCompletion are flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #18733:
URL: https://github.com/apache/kafka/pull/18733#discussion_r1933042732
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -115,7 +115,7 @@ class ReplicaManagerTest {
private var mockRemoteLogManager: RemoteLogManager = _
private var addPartitionsToTxnManager: AddPartitionsToTxnManager = _
private var brokerTopicStats: BrokerTopicStats = _
- private val transactionSupportedOperation = genericErrorSupported
+ private var transactionSupportedOperation: TransactionSupportedOperation = genericErrorSupported
Review Comment:
Is this only used in each test once? If so maybe it doesn't need to be a global var. If it's just one that uses a variant, we can define it separately in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #18733:
URL: https://github.com/apache/kafka/pull/18733#discussion_r1933043496
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -738,12 +738,20 @@ class ReplicaManager(val config: KafkaConfig,
// retry correctly. Translate these to an error which will cause such clients to retry
// the produce request. We pick `NOT_ENOUGH_REPLICAS` because it does not trigger a
// metadata refresh.
- case Errors.CONCURRENT_TRANSACTIONS |
- Errors.NETWORK_EXCEPTION |
+ case Errors.NETWORK_EXCEPTION |
Errors.COORDINATOR_LOAD_IN_PROGRESS |
Errors.COORDINATOR_NOT_AVAILABLE |
Errors.NOT_COORDINATOR => Some(new NotEnoughReplicasException(
s"Unable to verify the partition has been added to the transaction. Underlying error: ${error.toString}"))
+ case Errors.CONCURRENT_TRANSACTIONS =>
+ if (transactionSupportedOperation != addPartition) {
Review Comment:
I have a PR open that can make this check easier. Depending on what goes in first, we can modify. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #18733:
URL: https://github.com/apache/kafka/pull/18733#issuecomment-2620334877
Thanks Calvin! Looks pretty good. Just left a few minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
Posted by "CalvinConfluent (via GitHub)" <gi...@apache.org>.
CalvinConfluent commented on code in PR #18733:
URL: https://github.com/apache/kafka/pull/18733#discussion_r1933065294
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -115,7 +115,7 @@ class ReplicaManagerTest {
private var mockRemoteLogManager: RemoteLogManager = _
private var addPartitionsToTxnManager: AddPartitionsToTxnManager = _
private var brokerTopicStats: BrokerTopicStats = _
- private val transactionSupportedOperation = genericErrorSupported
+ private var transactionSupportedOperation: TransactionSupportedOperation = genericErrorSupported
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #18733:
URL: https://github.com/apache/kafka/pull/18733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18662: Return CONCURRENT_TRANSACTIONS on produce request in TV2 [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #18733:
URL: https://github.com/apache/kafka/pull/18733#issuecomment-2620328945
Thanks Calvin! Can we also add the error to the list in ProduceResponse.java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org