You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/04/13 10:17:18 UTC
[GitHub] [flink-connector-pulsar] tisonkun opened a new pull request, #43: [FLINK-31748] Dummy implementation to fix compilation failure
tisonkun opened a new pull request, #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43
TRIVIAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43#discussion_r1165322478
##########
.github/workflows/daily.yml:
##########
@@ -18,6 +18,7 @@
name: Nightly
on:
+ pull_request:
Review Comment:
To be reverted after verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] tisonkun merged pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43#issuecomment-1520993271
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43#discussion_r1165364566
##########
.github/workflows/daily.yml:
##########
@@ -18,6 +18,7 @@
name: Nightly
on:
+ pull_request:
Review Comment:
```suggestion
```
Verified. Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43#discussion_r1174672717
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarSourceFetcherManager.java:
##########
@@ -86,6 +86,11 @@ public void addSplits(List<PulsarPartitionSplit> splitsToAdd) {
}
}
+ // @Override // to keep compatible with Flink 1.17
+ public void removeSplits(List<PulsarPartitionSplit> splitsToRemove) {
+ // empty - wait for FLINK-31748 to implement it.
Review Comment:
```suggestion
// TODO empty - wait for FLINK-31748 to implement it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #43:
URL: https://github.com/apache/flink-connector-pulsar/pull/43#discussion_r1165713014
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarSourceFetcherManager.java:
##########
@@ -86,6 +86,11 @@ public void addSplits(List<PulsarPartitionSplit> splitsToAdd) {
}
}
+ // @Override // to keep compatible with Flink 1.17
+ public void removeSplits(List<PulsarPartitionSplit> splitsToRemove) {
+ // empty - wait for FLINK-31748 to implement it.
Review Comment:
Maybe we can add a `TODO` tag here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org