You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/04/04 16:04:25 UTC

[GitHub] flink pull request: [FLINK-2609] [streaming] auto-register types

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1833#issuecomment-205307922
  
    Let's not merge this as is, it uses again a static de-duplicator, like the DataSet API used to (we recently eliminated that). These static utils to work around putting adding variable in the right place is an antipattern.
    
    Why not have the registration de-duplicator in the ExecutionEnvironment? Since the ExecutionCondig is also one-per environment, and is always accessed through the environment, that seems like the way to go...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---