You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/11/06 09:12:00 UTC
[PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
xinyiZzz opened a new pull request, #26465:
URL: https://github.com/apache/doris/pull/26465
## Proposed changes
common expr pushdown in
dup key table,
unique key MoW table,
unique key MoR table and agg key table must satisfy all expr slot is key column.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803782656
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.66 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162420425 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803682457
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26465: [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column.
URL: https://github.com/apache/doris/pull/26465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794516452
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.18 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162265929 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803756426
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803639651
TeamCity be ut coverage result:
Function Coverage: 36.74% (8398/22858)
Line Coverage: 29.26% (68120/232837)
Region Coverage: 27.91% (35241/126288)
Branch Coverage: 24.71% (18020/72928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/11b0d8f9b7d9993532f1eb3405ce1849070925b2_11b0d8f9b7d9993532f1eb3405ce1849070925b2/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #26465:
URL: https://github.com/apache/doris/pull/26465#discussion_r1387211883
##########
be/src/olap/schema.h:
##########
@@ -176,6 +176,14 @@ class Schema {
const std::vector<int32_t>& unique_ids() const { return _unique_ids; }
ColumnId column_id(size_t index) const { return _col_ids[index]; }
int32_t unique_id(size_t index) const { return _unique_ids[index]; }
+ size_t unique_id_to_index(int32_t unique_id) const {
Review Comment:
warning: method 'unique_id_to_index' can be made static [readability-convert-member-functions-to-static]
```suggestion
static size_t unique_id_to_index(int32_t unique_id) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794388833
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803717839
TeamCity be ut coverage result:
Function Coverage: 36.73% (8396/22858)
Line Coverage: 29.24% (68093/232838)
Region Coverage: 27.89% (35225/126288)
Branch Coverage: 24.70% (18014/72928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/33367e895673a6f6bb15a1b58cf6bc571e3cfa98_33367e895673a6f6bb15a1b58cf6bc571e3cfa98/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803839575
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit edf2d9937da758cef7cc65cb5fd97ab9be77c569, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5276 5190 5099 5099
q2 369 186 198 186
q3 2098 2136 2079 2079
q4 1506 1435 1431 1431
q5 4166 4200 4105 4105
q6 256 134 132 132
q7 2076 1607 1607 1607
q8 2775 2756 2786 2756
q9 10389 10242 10302 10242
q10 3487 3576 3584 3576
q11 382 255 254 254
q12 455 297 293 293
q13 4497 4143 4090 4090
q14 330 299 305 299
q15 663 561 568 561
q16 691 630 602 602
q17 1162 1107 1085 1085
q18 7856 7317 7566 7317
q19 1701 1715 1724 1715
q20 614 368 353 353
q21 4955 4609 4544 4544
q22 546 430 450 430
Total cold run time: 56250 ms
Total hot run time: 52756 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5039 4949 5000 4949
q2 343 244 239 239
q3 4035 3910 3984 3910
q4 2781 2749 2733 2733
q5 6655 6627 6588 6588
q6 245 124 127 124
q7 3178 2700 2718 2700
q8 4933 4833 4851 4833
q9 17757 17663 17684 17663
q10 4109 4168 4170 4168
q11 731 672 652 652
q12 1019 807 841 807
q13 4339 3923 3917 3917
q14 393 348 357 348
q15 603 564 564 564
q16 810 686 688 686
q17 3972 3948 3921 3921
q18 9484 9007 9250 9007
q19 1933 1816 1782 1782
q20 2383 2099 2039 2039
q21 8858 8753 8677 8677
q22 905 839 833 833
Total cold run time: 84505 ms
Total hot run time: 81140 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803860714
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.14 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162240579 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #26465:
URL: https://github.com/apache/doris/pull/26465#discussion_r1387795358
##########
be/src/olap/schema.h:
##########
@@ -176,6 +176,15 @@ class Schema {
const std::vector<int32_t>& unique_ids() const { return _unique_ids; }
ColumnId column_id(size_t index) const { return _col_ids[index]; }
int32_t unique_id(size_t index) const { return _unique_ids[index]; }
+ size_t col_id_to_col_ids_index(int cid) const {
Review Comment:
warning: method 'col_id_to_col_ids_index' can be made static [readability-convert-member-functions-to-static]
```suggestion
static size_t col_id_to_col_ids_index(int cid) {
```
##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -104,6 +104,26 @@ static std::string read_columns_to_string(TabletSchemaSPtr tablet_schema,
return read_columns_string;
}
+void NewOlapScanner::_perfect_slot_column_id(const VExprSPtr& expr) {
Review Comment:
warning: method '_perfect_slot_column_id' can be made static [readability-convert-member-functions-to-static]
be/src/vec/exec/scan/new_olap_scanner.h:89:
```diff
- void _perfect_slot_column_id(const VExprSPtr& expr);
+ static void _perfect_slot_column_id(const VExprSPtr& expr);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1802686789
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803879585
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 2dcf6a9d038aa748df396aa4fde989728d4d2c3a, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5208 5074 5075 5074
q2 377 178 199 178
q3 2080 2064 2048 2048
q4 1487 1460 1427 1427
q5 4112 4153 4106 4106
q6 254 133 134 133
q7 2088 1618 1638 1618
q8 2775 2750 2762 2750
q9 10650 10546 10211 10211
q10 3476 3591 3574 3574
q11 376 253 256 253
q12 456 294 293 293
q13 4551 4131 4113 4113
q14 324 287 298 287
q15 646 570 564 564
q16 697 617 587 587
q17 1144 1104 1098 1098
q18 7894 7392 7393 7392
q19 1715 1711 1706 1706
q20 604 379 352 352
q21 4968 4600 4591 4591
q22 547 427 426 426
Total cold run time: 56429 ms
Total hot run time: 52781 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4989 4947 5065 4947
q2 354 262 250 250
q3 4041 3958 3842 3842
q4 2800 2807 2768 2768
q5 6496 6466 6635 6466
q6 243 126 127 126
q7 3181 2737 2662 2662
q8 4828 4727 4766 4727
q9 17934 17787 17820 17787
q10 4099 4139 4164 4139
q11 747 655 645 645
q12 1059 826 857 826
q13 4328 3884 3895 3884
q14 389 359 346 346
q15 640 567 581 567
q16 800 687 714 687
q17 3875 3967 3899 3899
q18 9461 9597 9283 9283
q19 1785 1776 1790 1776
q20 2388 2034 2066 2034
q21 8907 8733 8891 8733
q22 943 902 863 863
Total cold run time: 84287 ms
Total hot run time: 81257 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794389287
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794736179
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.26 seconds
stream load tsv: 550 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162155908 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26465: [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column.
URL: https://github.com/apache/doris/pull/26465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794436421
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794666674
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #26465:
URL: https://github.com/apache/doris/pull/26465#discussion_r1387891982
##########
be/src/olap/schema.h:
##########
@@ -176,6 +176,15 @@ class Schema {
const std::vector<int32_t>& unique_ids() const { return _unique_ids; }
ColumnId column_id(size_t index) const { return _col_ids[index]; }
int32_t unique_id(size_t index) const { return _unique_ids[index]; }
+ int32_t col_id_to_col_ids_index(int cid) const {
Review Comment:
warning: method 'col_id_to_col_ids_index' can be made static [readability-convert-member-functions-to-static]
```suggestion
static size_t col_id_to_col_ids_index(int cid) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803674073
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #26465:
URL: https://github.com/apache/doris/pull/26465#discussion_r1387899932
##########
be/src/olap/schema.h:
##########
@@ -176,6 +176,15 @@ class Schema {
const std::vector<int32_t>& unique_ids() const { return _unique_ids; }
ColumnId column_id(size_t index) const { return _col_ids[index]; }
int32_t unique_id(size_t index) const { return _unique_ids[index]; }
+ int32_t col_id_to_col_ids_index(int cid) const {
Review Comment:
warning: method 'col_id_to_col_ids_index' can be made static [readability-convert-member-functions-to-static]
```suggestion
static int32_t col_id_to_col_ids_index(int cid) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803753451
TeamCity be ut coverage result:
Function Coverage: 36.73% (8395/22858)
Line Coverage: 29.24% (68092/232838)
Region Coverage: 27.89% (35217/126288)
Branch Coverage: 24.70% (18011/72928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/edf2d9937da758cef7cc65cb5fd97ab9be77c569_edf2d9937da758cef7cc65cb5fd97ab9be77c569/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803800808
TeamCity be ut coverage result:
Function Coverage: 36.74% (8398/22856)
Line Coverage: 29.24% (68084/232833)
Region Coverage: 27.91% (35242/126286)
Branch Coverage: 24.71% (18022/72928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2dcf6a9d038aa748df396aa4fde989728d4d2c3a_2dcf6a9d038aa748df396aa4fde989728d4d2c3a/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-2099502115
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794615280
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794700745
TeamCity be ut coverage result:
Function Coverage: 37.00% (8393/22684)
Line Coverage: 29.43% (67925/230775)
Region Coverage: 28.11% (35147/125038)
Branch Coverage: 24.90% (17958/72110)
Coverage Report: http://coverage.selectdb-in.cc/coverage/eb7dfa1cf9ff0ac70d73e768d21969a03e170065_eb7dfa1cf9ff0ac70d73e768d21969a03e170065/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794453910
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1794479214
TeamCity be ut coverage result:
Function Coverage: 37.00% (8393/22683)
Line Coverage: 29.44% (67923/230753)
Region Coverage: 28.11% (35143/125017)
Branch Coverage: 24.90% (17952/72098)
Coverage Report: http://coverage.selectdb-in.cc/coverage/42f153d07157793a5cbfdfd66bfcd29a8234ac75_42f153d07157793a5cbfdfd66bfcd29a8234ac75/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #26465:
URL: https://github.com/apache/doris/pull/26465#issuecomment-1803547139
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org