You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Sutou Kouhei <ko...@clear-code.com> on 2020/12/16 21:58:40 UTC
[C++] Minimum CMake version
Hi,
We require CMake 3.2 or later. Can we require more newer
CMake? I don't to want to add workaround for CMake 3.2 like
this:
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79
# CMake 3.2 does uppercase the FOUND variable
if(re2Alt_FOUND OR RE2ALT_FOUND)
Ubuntu 16.04 ships CMake 3.5.1:
https://packages.ubuntu.com/search?keywords=cmake
CentOS 7 doesn't ship CMake 3 but EPEL provides CMake 3.17:
https://src.fedoraproject.org/rpms/cmake3/blob/epel7/f/cmake3.spec
Can we require CMake 3.5 or later?
Thanks,
--
kou
Re: [C++] Minimum CMake version
Posted by Wes McKinney <we...@gmail.com>.
I support raising the minimum version.
On Wed, Dec 16, 2020 at 3:59 PM Sutou Kouhei <ko...@clear-code.com> wrote:
> Hi,
>
> We require CMake 3.2 or later. Can we require more newer
> CMake? I don't to want to add workaround for CMake 3.2 like
> this:
>
>
> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79
>
> # CMake 3.2 does uppercase the FOUND variable
> if(re2Alt_FOUND OR RE2ALT_FOUND)
>
>
> Ubuntu 16.04 ships CMake 3.5.1:
>
> https://packages.ubuntu.com/search?keywords=cmake
>
> CentOS 7 doesn't ship CMake 3 but EPEL provides CMake 3.17:
>
> https://src.fedoraproject.org/rpms/cmake3/blob/epel7/f/cmake3.spec
>
>
> Can we require CMake 3.5 or later?
>
>
> Thanks,
> --
> kou
>
Re: [C++] Minimum CMake version
Posted by Antoine Pitrou <an...@python.org>.
Le 16/12/2020 à 22:58, Sutou Kouhei a écrit :
> Hi,
>
> We require CMake 3.2 or later. Can we require more newer
> CMake? I don't to want to add workaround for CMake 3.2 like
> this:
>
> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79
>
> # CMake 3.2 does uppercase the FOUND variable
> if(re2Alt_FOUND OR RE2ALT_FOUND)
>
>
> Ubuntu 16.04 ships CMake 3.5.1:
>
> https://packages.ubuntu.com/search?keywords=cmake
>
> CentOS 7 doesn't ship CMake 3 but EPEL provides CMake 3.17:
>
> https://src.fedoraproject.org/rpms/cmake3/blob/epel7/f/cmake3.spec
>
>
> Can we require CMake 3.5 or later?
+1 from me.
Regards
Antoine.
Re: [C++] Minimum CMake version
Posted by Sutou Kouhei <ko...@clear-code.com>.
Merged.
In <20...@clear-code.com>
"Re: [C++] Minimum CMake version" on Sun, 20 Dec 2020 15:55:51 +0900 (JST),
Sutou Kouhei <ko...@clear-code.com> wrote:
> Hi,
>
> I've implemented:
> https://github.com/apache/arrow/pull/8972
>
> If there is no objection, I'll merge this.
>
>
> Thanks,
> --
> kou
>
> In <20...@clear-code.com>
> "[C++] Minimum CMake version" on Thu, 17 Dec 2020 06:58:40 +0900 (JST),
> Sutou Kouhei <ko...@clear-code.com> wrote:
>
>> Hi,
>>
>> We require CMake 3.2 or later. Can we require more newer
>> CMake? I don't to want to add workaround for CMake 3.2 like
>> this:
>>
>> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79
>>
>> # CMake 3.2 does uppercase the FOUND variable
>> if(re2Alt_FOUND OR RE2ALT_FOUND)
>>
>>
>> Ubuntu 16.04 ships CMake 3.5.1:
>>
>> https://packages.ubuntu.com/search?keywords=cmake
>>
>> CentOS 7 doesn't ship CMake 3 but EPEL provides CMake 3.17:
>>
>> https://src.fedoraproject.org/rpms/cmake3/blob/epel7/f/cmake3.spec
>>
>>
>> Can we require CMake 3.5 or later?
>>
>>
>> Thanks,
>> --
>> kou
Re: [C++] Minimum CMake version
Posted by Sutou Kouhei <ko...@clear-code.com>.
Hi,
I've implemented:
https://github.com/apache/arrow/pull/8972
If there is no objection, I'll merge this.
Thanks,
--
kou
In <20...@clear-code.com>
"[C++] Minimum CMake version" on Thu, 17 Dec 2020 06:58:40 +0900 (JST),
Sutou Kouhei <ko...@clear-code.com> wrote:
> Hi,
>
> We require CMake 3.2 or later. Can we require more newer
> CMake? I don't to want to add workaround for CMake 3.2 like
> this:
>
> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79
>
> # CMake 3.2 does uppercase the FOUND variable
> if(re2Alt_FOUND OR RE2ALT_FOUND)
>
>
> Ubuntu 16.04 ships CMake 3.5.1:
>
> https://packages.ubuntu.com/search?keywords=cmake
>
> CentOS 7 doesn't ship CMake 3 but EPEL provides CMake 3.17:
>
> https://src.fedoraproject.org/rpms/cmake3/blob/epel7/f/cmake3.spec
>
>
> Can we require CMake 3.5 or later?
>
>
> Thanks,
> --
> kou