You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/11/02 07:57:38 UTC
[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11861
Change subject: [test] optional table creation in TabletServerIntegrationTestBase
......................................................................
[test] optional table creation in TabletServerIntegrationTestBase
Creation of the test table in TabletServerIntegrationTestBase is now
optional. If not specified otherwise, the test table is created by
default, preserving the original behavior.
The motivation for this change is that sometimes a derived test
might need the functionality of the TabletServerIntegrationTestBase
but expects not a single table created after SetUp().
The updated behavior will be used in a follow-up patch.
Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
---
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
2 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11861/1
--
To view, visit http://gerrit.cloudera.org:8080/11861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
Gerrit-Change-Number: 11861
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11861 )
Change subject: [test] optional table creation in TabletServerIntegrationTestBase
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11861/1/src/kudu/integration-tests/ts_itest-base.cc
File src/kudu/integration-tests/ts_itest-base.cc:
http://gerrit.cloudera.org:8080/#/c/11861/1/src/kudu/integration-tests/ts_itest-base.cc@550
PS1, Line 550: if (create_table) {
: NO_FATALS(CreateTable());
: }
: if (create_table) {
: WaitForTSAndReplicas();
: ASSERT_FALSE(tablet_replicas_.empty());
: tablet_id_ = (*tablet_replicas_.begin()).first;
: } else {
: WaitForTabletServers();
: }
Combine?
--
To view, visit http://gerrit.cloudera.org:8080/11861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
Gerrit-Change-Number: 11861
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 02 Nov 2018 15:49:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11861 )
Change subject: [test] optional table creation in TabletServerIntegrationTestBase
......................................................................
[test] optional table creation in TabletServerIntegrationTestBase
Creation of the test table in TabletServerIntegrationTestBase is now
optional. If not specified otherwise, the test table is created by
default, preserving the original behavior.
The motivation for this change is that sometimes a derived test
might need the functionality of the TabletServerIntegrationTestBase
but expects not a single table created after SetUp().
The updated behavior will be used in a follow-up patch.
Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
Reviewed-on: http://gerrit.cloudera.org:8080/11861
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
2 files changed, 24 insertions(+), 12 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
Gerrit-Change-Number: 11861
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11861
to look at the new patch set (#2).
Change subject: [test] optional table creation in TabletServerIntegrationTestBase
......................................................................
[test] optional table creation in TabletServerIntegrationTestBase
Creation of the test table in TabletServerIntegrationTestBase is now
optional. If not specified otherwise, the test table is created by
default, preserving the original behavior.
The motivation for this change is that sometimes a derived test
might need the functionality of the TabletServerIntegrationTestBase
but expects not a single table created after SetUp().
The updated behavior will be used in a follow-up patch.
Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
---
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
2 files changed, 24 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11861/2
--
To view, visit http://gerrit.cloudera.org:8080/11861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
Gerrit-Change-Number: 11861
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11861 )
Change subject: [test] optional table creation in TabletServerIntegrationTestBase
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I818a2eaf76fdee11ae792c27eddae311b775efeb
Gerrit-Change-Number: 11861
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 02 Nov 2018 18:35:55 +0000
Gerrit-HasComments: No