You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zhipeng93 (via GitHub)" <gi...@apache.org> on 2023/08/15 09:05:04 UTC
[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #250: [FLINK-32810] Improve memory allocation in ListStateWithCache
zhipeng93 commented on code in PR #250:
URL: https://github.com/apache/flink-ml/pull/250#discussion_r1294355543
##########
flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/ListStateWithCache.java:
##########
@@ -62,14 +63,32 @@ public class ListStateWithCache<T> implements ListState<T> {
/** The data cache writer for the received records. */
private final DataCacheWriter<T> dataCacheWriter;
- @SuppressWarnings("unchecked")
public ListStateWithCache(
TypeSerializer<T> serializer,
StreamTask<?, ?> containingTask,
StreamingRuntimeContext runtimeContext,
StateInitializationContext stateInitializationContext,
OperatorID operatorID)
throws IOException {
+ this(
+ serializer,
+ containingTask,
+ runtimeContext,
+ stateInitializationContext,
+ operatorID,
+ 0.);
Review Comment:
Would it be better to set the default value as 1.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org