[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #3050: fix: Don't apply blocking layer when service support blocking

["suyanhanx (via GitHub)" <gi...@apache.org>]

suyanhanx commented on code in PR #3050:
URL: https://github.com/apache/incubator-opendal/pull/3050#discussion_r1324139750


##########
core/src/layers/blocking.rs:
##########
@@ -25,13 +25,11 @@ use crate::raw::oio::ReadExt;
 use crate::raw::*;
 use crate::*;
 
-/// Add blocking API support for every operations.
+/// Add blocking API support for non-blocking services.
 ///
-/// # Blocking API
+/// # Notes
 ///
-/// - This layer is auto-added to the operator if it's accessor doesn't support blocking APIs.
-///
-/// Tracking issue: #2678
+/// Please only enable this layer when underlying services are not blocking.

Review Comment:
   ```suggestion
   /// Please only enable this layer when the underlying service does not support blocking.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org