You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/01/29 23:38:34 UTC
Review Request 42979: Enable ping query to prevent use of invalid
pooled connections.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42979/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-1596
https://issues.apache.org/jira/browse/AURORA-1596
Repository: aurora
Description
-------
Enable ping query to prevent use of invalid pooled connections.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 8b8c54a116726aa7d3400a54df6439fd368258e7
Diff: https://reviews.apache.org/r/42979/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 42979: Enable ping query to prevent use of invalid
pooled connections.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42979/#review117037
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 29, 2016, 2:38 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42979/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 2:38 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Enable ping query to prevent use of invalid pooled connections.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 8b8c54a116726aa7d3400a54df6439fd368258e7
>
> Diff: https://reviews.apache.org/r/42979/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42979: Enable ping query to prevent use of invalid
pooled connections.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42979/#review117042
-----------------------------------------------------------
Master (0eb753d) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 29, 2016, 10:38 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42979/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 10:38 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Enable ping query to prevent use of invalid pooled connections.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 8b8c54a116726aa7d3400a54df6439fd368258e7
>
> Diff: https://reviews.apache.org/r/42979/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42979: Enable ping query to prevent use of invalid
pooled connections.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42979/#review117226
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Jan. 29, 2016, 10:38 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42979/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 10:38 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Enable ping query to prevent use of invalid pooled connections.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 8b8c54a116726aa7d3400a54df6439fd368258e7
>
> Diff: https://reviews.apache.org/r/42979/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>