You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (JIRA)" <ji...@apache.org> on 2018/11/24 14:26:00 UTC
[jira] [Commented] (YARN-9052) Replace all MockRM submit method
definitions with builder
[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697836#comment-16697836 ]
Szilard Nemeth commented on YARN-9052:
--------------------------------------
Uploaded preliminary patch, waiting for test results from Jenkins.
> Replace all MockRM submit method definitions with builder
> ---------------------------------------------------------
>
> Key: YARN-9052
> URL: https://issues.apache.org/jira/browse/YARN-9052
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-9052.001.patch
>
>
> MockRM has 31 definitions of submitApp, most of them having more than acceptable number of parameters, ranging from 2 to even 22 parameters, which makes the code completely unreadable.
> On top of unreadability, it's very hard to follow what RmApp will be produced for tests as they often pass a lot of empty / null values as parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org