You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Tianyin Xu (JIRA)" <ji...@apache.org> on 2015/12/22 07:39:46 UTC
[jira] [Updated] (HBASE-15026) The default value of
"hbase.regions.slop" is obsolete
[ https://issues.apache.org/jira/browse/HBASE-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tianyin Xu updated HBASE-15026:
-------------------------------
Attachment: HBASE.15026.patch.001
> The default value of "hbase.regions.slop" is obsolete
> -----------------------------------------------------
>
> Key: HBASE-15026
> URL: https://issues.apache.org/jira/browse/HBASE-15026
> Project: HBase
> Issue Type: Bug
> Components: Balancer
> Affects Versions: 1.1.2
> Reporter: Tianyin Xu
> Attachments: HBASE.15026.patch.001
>
>
> The default value of {{hbase.regions.slop}} is {{0.001}} in {{StochasticLoadBalancer}} (which is the default setting of {{hbase.master.loadbalancer.class}}).
> However, in the docs (both {{hbase-default.xml}} and [online docs|http://hbase.apache.org/book.html#config.files]), the default value is {{0.2}}. This value is specified in {{BaseLoadBalancer}} (which is an abstract class) and is inherited by {{SimpleLoadBalancer}}. However, as {{SimpleLoadBalancer}} is no longer used as the default load balancer, the doc is obsolete.
> The code structure is:
> {code:title=BaseLoadBalancer.java|borderStyle=solid}
> public abstract class BaseLoadBalancer implements LoadBalancer {
> ...
> protected void setSlop(Configuration conf) {
> this.slop = conf.getFloat("hbase.regions.slop", (float) 0.2);
> }
> {code}
> {code:title=StochasticLoadBalancer.java|borderStyle=solid}
> public class StochasticLoadBalancer extends BaseLoadBalancer {
> ...
> @Override
> protected void setSlop(Configuration conf) {
> this.slop = conf.getFloat("hbase.regions.slop", 0.001F);
> }
> {code}
> I suggest to make the manual entry of {{hbase.regions.slop}} specify the different default values in different balancer classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)