You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/30 22:22:47 UTC
[GitHub] [netbeans] Chris2011 opened a new pull request, #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Chris2011 opened a new pull request, #5034:
URL: https://github.com/apache/netbeans/pull/5034
**^Add meaningful description above**
After finding a weird context mentu entry, I started investigating what this is and here you can read more about it: https://github.com/apache/netbeans/discussions/4894
So before the fix, the string looked like Editors/Popup/mimeType which was wrong and lead to misbehavior of EditorActions in PopupMenus (Context menu). After the fix, it looks correct now Editors/mimeType/Popup. The 2 actions were added just for the Java Shell support but because of wrong order, the action were added for each editor.
Also I removed unnecessary layer.xml entry which led to an empty etnry after the original fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #5034:
URL: https://github.com/apache/netbeans/pull/5034#issuecomment-1335493433
If there are no other things to know, I would like to merge this somewhen next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 merged pull request #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Posted by GitBox <gi...@apache.org>.
Chris2011 merged PR #5034:
URL: https://github.com/apache/netbeans/pull/5034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5034:
URL: https://github.com/apache/netbeans/pull/5034#issuecomment-1335811868
@Chris2011 thank you for the typo update, but sorry, the fix for the author did not take. Have a look at your commit with the git CLI (forget github, it is still crap for these kinds of checks). Run `git log -n 2` on this branch. Only your second commit holds the right author information.
This looks like a good hint: https://www.deployhq.com/git/faqs/update-author-committer-multiple-git-commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #5034:
URL: https://github.com/apache/netbeans/pull/5034#issuecomment-1334435348
> Change looks good. Would you mind to also fix a typo in `jshell`?:
>
> ```diff
> --- a/java/jshell.support/src/org/netbeans/modules/jshell/editor/Bundle.properties
> +++ b/java/jshell.support/src/org/netbeans/modules/jshell/editor/Bundle.properties
> @@ -24,7 +24,7 @@
>
> jshell-execute=Execute Shell Input
> jshell-reset=Reset Java Shell
> -jshell-stop=Interrupt exeution
> +jshell-stop=Interrupt execution
> jshell-save-to-class=Save To Class
> ClassNamePanel.className.text=
> ClassNamePanel.message.text=\
> ```
>
> One other thing: As author "Chris2011" is shown. Please update that to your full name, it is present in the email adress, but should be completely valid.
Thx for the review and the info, will fix the typo and change the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #5034:
URL: https://github.com/apache/netbeans/pull/5034#issuecomment-1334502877
> One other thing: As author "Chris2011" is shown. Please update that to your full name, it is present in the email adress, but should be completely valid.
I'm sry, I changed that within the NetBeans commit Dialog for Author and Commiter from Chris2011 <ch...@gmx.net> but it seems that it didn't work. This is what you meant, for the commits right? Will change it via git cli.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #5034:
URL: https://github.com/apache/netbeans/pull/5034#issuecomment-1335943614
@matthiasblaesing now it should be fine, I guess :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists