[GitHub] [pulsar] congbobo184 opened a new pull request, #16266: [fix][txn] Fix append txn message is lower than lowWaterMark decrease PendingWriteOps

[GitBox <gi...@apache.org>]

congbobo184 opened a new pull request, #16266:
URL: https://github.com/apache/pulsar/pull/16266

   ### Motivation
   when send txn message is lower than low watermark, tb will throw`NotAllowedException`, but now we don't decrease PendingWriteOps, if PendingWriteOps != 0 and managed ledger in `WriteFailed` state, we can't roll over the ledger and create a new ledger.
   
   https://github.com/apache/pulsar/blob/336fcb0cf848d59fde1a35c5618c7a005b7ddfc4/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L492-L507
   
   ### Modifications
   when tb throw `NotAllowedException`, we should do decrementPendingWriteOpsAndCheck
   ### Verifying this change
   add the check for pendingWriteOps
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduces a new feature? (yes)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #16266: [fix][txn] Fix append txn message is lower than lowWaterMark decrease PendingWriteOps

[GitBox <gi...@apache.org>]

codelipenghui merged PR #16266:
URL: https://github.com/apache/pulsar/pull/16266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org