You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/19 02:32:43 UTC
[GitHub] [superset] lyndsiWilliams commented on a change in pull request #17944: chore: migrate QueryTable component from jsx to tsx
lyndsiWilliams commented on a change in pull request #17944:
URL: https://github.com/apache/superset/pull/17944#discussion_r787187996
##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -200,7 +232,7 @@ const QueryTable = props => {
q.sql = (
<Card css={[StaticPosition]}>
<HighlightedSql
- sql={q.sql}
+ sql={sql}
Review comment:
I think `q.` needs to stay here and in the subsequent spots you removed it below (I'll mark them with comments). Was this removed for a reason?
##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -240,17 +272,14 @@ const QueryTable = props => {
q.output = [schemaUsed, q.tempTable].filter(v => v).join('.');
}
q.progress =
- q.state === 'success' ? (
+ state === 'success' ? (
<ProgressBar
- percent={parseInt(q.progress.toFixed(0), 10)}
+ percent={parseInt(progress.toFixed(0), 10)}
Review comment:
`q.` should remain here
##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -240,17 +272,14 @@ const QueryTable = props => {
q.output = [schemaUsed, q.tempTable].filter(v => v).join('.');
}
q.progress =
- q.state === 'success' ? (
+ state === 'success' ? (
<ProgressBar
- percent={parseInt(q.progress.toFixed(0), 10)}
+ percent={parseInt(progress.toFixed(0), 10)}
striped
showInfo={false}
/>
) : (
- <ProgressBar
- percent={parseInt(q.progress.toFixed(0), 10)}
- striped
- />
+ <ProgressBar percent={parseInt(progress.toFixed(0), 10)} striped />
Review comment:
`q.` should remain here
##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -240,17 +272,14 @@ const QueryTable = props => {
q.output = [schemaUsed, q.tempTable].filter(v => v).join('.');
}
q.progress =
- q.state === 'success' ? (
+ state === 'success' ? (
Review comment:
`q.` should remain here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org