You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/02 10:30:00 UTC

[jira] [Commented] (FLINK-9521) Add shade plugin executions to package table example jar

    [ https://issues.apache.org/jira/browse/FLINK-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529672#comment-16529672 ] 

ASF GitHub Bot commented on FLINK-9521:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/6123
  
    I'm with Till here. The example JARs add very little value. I would be OK with adding them if this was lightweight, but each example will include the Table API and its dependencies (incl. Calcite and Janino) and hence be 16MB in size. 
    
    So adding these examples to the distribution adds 80MB in total for very little value. 
    Hence, I would not add them to the distribution.


> Add shade plugin executions to package table example jar
> --------------------------------------------------------
>
>                 Key: FLINK-9521
>                 URL: https://issues.apache.org/jira/browse/FLINK-9521
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.6.0, 1.5.1
>
>
> this is a preparatory work for issue FLINK-9519, so that we can get those examples' fat jar and then move them to example dir like batch and streaming. Because, there is no table examples in flink binary package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)