You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/20 04:59:52 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer
brusdev opened a new pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590#discussion_r638039922
##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/Transfer.java
##########
@@ -105,10 +105,207 @@
@Option(name = "--target-topic", description = "Destination to be used. It can be prefixed with queue:// or topic:// and can be an FQQN in the form of <address>::<queue>. (Default: queue://TEST)")
String targetTopic;
- boolean isCopy() {
+ @Option(name = "--max-count", description = "The maximum number of messages to transfer.")
Review comment:
Seems pretty much the same to me.
./artemis consumer --message-count means.. the name of messages to consume...
While
./artemis transfer --message-count would mean the maximum number of messages to transfer.
it would keep CLI clean. things would get easier to remember when you move from one tool to another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590#discussion_r638064339
##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/Transfer.java
##########
@@ -105,10 +105,207 @@
@Option(name = "--target-topic", description = "Destination to be used. It can be prefixed with queue:// or topic:// and can be an FQQN in the form of <address>::<queue>. (Default: queue://TEST)")
String targetTopic;
- boolean isCopy() {
+ @Option(name = "--max-count", description = "The maximum number of messages to transfer.")
Review comment:
I see, I have just pushed a commit to fix the parameter name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590#discussion_r637923463
##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/Transfer.java
##########
@@ -105,10 +105,207 @@
@Option(name = "--target-topic", description = "Destination to be used. It can be prefixed with queue:// or topic:// and can be an FQQN in the form of <address>::<queue>. (Default: queue://TEST)")
String targetTopic;
- boolean isCopy() {
+ @Option(name = "--max-count", description = "The maximum number of messages to transfer.")
Review comment:
The `max-count` parameter has a different name from `message-count` because it has a different semantic. The first one defines the maximum number of messages to transfer while the second one would define the exact number of messages to transfer waiting if the available messages are less than the `message-count` value (as the consumer does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590#discussion_r637285931
##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/Transfer.java
##########
@@ -105,10 +105,207 @@
@Option(name = "--target-topic", description = "Destination to be used. It can be prefixed with queue:// or topic:// and can be an FQQN in the form of <address>::<queue>. (Default: queue://TEST)")
String targetTopic;
- boolean isCopy() {
+ @Option(name = "--max-count", description = "The maximum number of messages to transfer.")
Review comment:
Can we make this consistent to ./artemis consumer... so this would come as --message-count ?
Can you check others...
if you want to expand towards those options.. isn't this something you could share a common base class with consumer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org