You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/24 00:07:23 UTC
[GitHub] [incubator-doris] yiguolei opened a new pull request, #9746: disable bloomfilter is pass rate is very high
yiguolei opened a new pull request, #9746:
URL: https://github.com/apache/incubator-doris/pull/9746
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
disable bloomfilter is pass rate is very high
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #9746: disable bloomfilter is pass rate is very high
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #9746:
URL: https://github.com/apache/incubator-doris/pull/9746#issuecomment-1135293628
Nice job, this optimization is also a TODO of the runtime filter: https://github.com/apache/incubator-doris/issues/6116
This helps reduce the performance penalty of the runtime filter in bad cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9746: disable bloomfilter is pass rate is very high
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9746:
URL: https://github.com/apache/incubator-doris/pull/9746#discussion_r880000234
##########
be/src/olap/bloom_filter_predicate.h:
##########
@@ -157,6 +160,14 @@ void BloomFilterColumnPredicate<T>::evaluate(vectorized::IColumn& column, uint16
new_size += _specific_filter->find_olap_engine(cell_value);
}
}
+ // If the pass rate is very high, for example > 50%, then the bloomfilter is useless.
+ _evaluated_rows += *size;
+ _passed_rows += new_size;
+ if (_evaluated_rows > 1000) {
Review Comment:
sure 1000 is a better row count ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei closed pull request #9746: disable bloomfilter is pass rate is very high
Posted by GitBox <gi...@apache.org>.
yiguolei closed pull request #9746: disable bloomfilter is pass rate is very high
URL: https://github.com/apache/incubator-doris/pull/9746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org