You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/21 16:47:05 UTC

[GitHub] [tvm-rfcs] tkonolige edited a comment on pull request #29: Migrating Target Attributes to IRModule

tkonolige edited a comment on pull request #29:
URL: https://github.com/apache/tvm-rfcs/pull/29#issuecomment-924166766


   I think this is a good and necessary change. Thanks!
   
   I agree with Andrew that it would be better to keep these parameters as a separate object. I think this makes a more consistent interface. We are all ready passing targets separately from the module, so it makes more logical sense to keep "RuntimeConfig" (or whatever you want to call it) separate. On the other hand, I'm also not opposed to moving target and "RuntimeConfig" into the IRModule. Passing around all these separate but related objects can be a pain and I think we are moving towards bundling them in the IRModule.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org