[jira] [Commented] (CASSANDRA-16483) ColumnFilter::toString doesn't return a valid CQL fragment

["Yifan Cai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295654#comment-17295654 ] 

Yifan Cai commented on CASSANDRA-16483:
---------------------------------------

Sorry to see that we missed the implicit call of {{ColumnFilter::toString}} during review. 
If the coming patch is still going to use the result of {{ColumnFilter::toString}} to produce the cqlString, may I suggest to call the {{toString()}} method explicitly? In that case, the IDE is able to find the usage at least. 

> ColumnFilter::toString doesn't return a valid CQL fragment
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-16483
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16483
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Logging
>            Reporter: Sam Tunnicliffe
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> This was changed in CASSANDRA-16415 to include indications about queried vs fetched reagular & static columns. However, the result is used by {{AbstractReadQuery::toCQLString}}, which causes it to produce an illegal query string.
> This breaks a couple of dtests because they're looking for CQL strings in logs, which are no longer found:
> * {{upgrade_tests/paging_test.py::TestPagingWithDeletions::test_failure_threshold_deletions}}
> * {{cql_test.py::TestCQLSlowQuery}} has a couple of failing tests, {{test_local_query/test_remote_query}}
> We should also check audit and fql logs (and any other place where {{toCQLString}} is used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org