You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/04/30 03:14:07 UTC

[Impala-ASF-CR] IMPALA-7971 (follow-up). Fix compilation error 

Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13184


Change subject: IMPALA-7971 (follow-up). Fix compilation error
......................................................................

IMPALA-7971 (follow-up). Fix compilation error

15a33d1ba was committed at about the same time as 5ced9160bd6, which
renamed one of the methods of the FileDescriptor class, causing a
compilation error. This follow-up mixes the semantic conflict.

Tested tests/custom_cluster/test_event_processing.py manually.

Change-Id: I8071b421f0dcbae2d303bd9f1e1f6f64657c49c0
---
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/13184/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8071b421f0dcbae2d303bd9f1e1f6f64657c49c0
Gerrit-Change-Number: 13184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-7971 (follow-up). Fix compilation error

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13184 )

Change subject: IMPALA-7971 (follow-up). Fix compilation error
......................................................................


Patch Set 1: Verified+1 Code-Review+2

Skipping GVO to unbreak the master build.


-- 
To view, visit http://gerrit.cloudera.org:8080/13184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8071b421f0dcbae2d303bd9f1e1f6f64657c49c0
Gerrit-Change-Number: 13184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 03:15:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7971 (follow-up). Fix compilation error

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13184 )

Change subject: IMPALA-7971 (follow-up). Fix compilation error
......................................................................

IMPALA-7971 (follow-up). Fix compilation error

15a33d1ba was committed at about the same time as 5ced9160bd6, which
renamed one of the methods of the FileDescriptor class, causing a
compilation error. This follow-up mixes the semantic conflict.

Tested tests/custom_cluster/test_event_processing.py manually.

Change-Id: I8071b421f0dcbae2d303bd9f1e1f6f64657c49c0
Reviewed-on: http://gerrit.cloudera.org:8080/13184
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8071b421f0dcbae2d303bd9f1e1f6f64657c49c0
Gerrit-Change-Number: 13184
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-7971 (follow-up). Fix compilation error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13184 )

Change subject: IMPALA-7971 (follow-up). Fix compilation error
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2991/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8071b421f0dcbae2d303bd9f1e1f6f64657c49c0
Gerrit-Change-Number: 13184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 04:13:00 +0000
Gerrit-HasComments: No