You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/07 18:57:46 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #10551: fix: embedded chart height
etr2460 opened a new pull request #10551:
URL: https://github.com/apache/incubator-superset/pull/10551
### SUMMARY
When this empty div was added, it broke `ParentSize` a few components down the stack, resulting in embedded charts rendering with 0 height. This fixes the issue.
I was trying to figure out a good way to write a unit test for this, but couldn't since it involves so many layers of components. Perhaps a snapshot test would be valuable in the future though
### TEST PLAN
CI, test an embedded chart
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @rusackas @graceguo-supercat @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10551: fix: embedded chart height
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10551:
URL: https://github.com/apache/incubator-superset/pull/10551#issuecomment-670675238
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=h1) Report
> Merging [#10551](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6fa02aaec1ec5cba1fa010cf6910f65a965eaf7&el=desc) will **increase** coverage by `4.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10551 +/- ##
==========================================
+ Coverage 59.32% 63.68% +4.36%
==========================================
Files 354 767 +413
Lines 22867 36298 +13431
Branches 0 3427 +3427
==========================================
+ Hits 13566 23117 +9551
- Misses 9301 13064 +3763
- Partials 0 117 +117
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.05% <ø> (?)` | |
| #javascript | `59.87% <ø> (?)` | |
| #python | `59.32% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `78.72% <0.00%> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <0.00%> (ø)` | |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `76.69% <0.00%> (ø)` | |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `29.41% <0.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.83% <0.00%> (ø)` | |
| [.../src/dashboard/components/FilterTooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlclRvb2x0aXBXcmFwcGVyLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.77% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `77.27% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | `8.62% <0.00%> (ø)` | |
| ... and [404 more](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=footer). Last update [a6fa02a...f57ecdc](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #10551: fix: embedded chart height
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10551:
URL: https://github.com/apache/incubator-superset/pull/10551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10551: fix: embedded chart height
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10551:
URL: https://github.com/apache/incubator-superset/pull/10551#issuecomment-670675238
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=h1) Report
> Merging [#10551](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6fa02aaec1ec5cba1fa010cf6910f65a965eaf7&el=desc) will **increase** coverage by `4.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10551 +/- ##
==========================================
+ Coverage 59.32% 63.85% +4.52%
==========================================
Files 354 767 +413
Lines 22867 36298 +13431
Branches 0 3427 +3427
==========================================
+ Hits 13566 23178 +9612
- Misses 9301 13008 +3707
- Partials 0 112 +112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.86% <ø> (?)` | |
| #javascript | `59.87% <ø> (?)` | |
| #python | `59.32% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `68.65% <0.00%> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=) | `95.23% <0.00%> (ø)` | |
| [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | `28.57% <0.00%> (ø)` | |
| [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | `89.65% <0.00%> (ø)` | |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `84.61% <0.00%> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `80.35% <0.00%> (ø)` | |
| [...nd/src/messageToasts/components/ToastPresenter.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci50c3g=) | `100.00% <0.00%> (ø)` | |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `100.00% <0.00%> (ø)` | |
| ... and [404 more](https://codecov.io/gh/apache/incubator-superset/pull/10551/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=footer). Last update [a6fa02a...f57ecdc](https://codecov.io/gh/apache/incubator-superset/pull/10551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org