You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/04/10 11:06:26 UTC
Review Request 58293: Need a way to indicate the action node type in
workflow manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58293/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.
Bugs: AMBARI-20704
https://issues.apache.org/jira/browse/AMBARI-20704
Repository: ambari
Description
-------
Currently there's no way for the user to know the action node type from workflow designer page.
We have added images for each action for easy representation.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 5a85573
contrib/views/wfmanager/src/main/resources/ui/app/index.html df243ad
contrib/views/wfmanager/src/main/resources/ui/public/assets/custom.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/distcp.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/email.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/fs.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/hive.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/hive2.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/java.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/map-reduce.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/pig.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/shell.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/spark.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/sqoop.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/ssh.png PRE-CREATION
contrib/views/wfmanager/src/main/resources/ui/public/assets/sub-workflow.png PRE-CREATION
Diff: https://reviews.apache.org/r/58293/diff/1/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 58293: Need a way to indicate the action node type
in workflow manager
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58293/#review171435
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On April 10, 2017, 11:06 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58293/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 11:06 a.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20704
> https://issues.apache.org/jira/browse/AMBARI-20704
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently there's no way for the user to know the action node type from workflow designer page.
> We have added images for each action for easy representation.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 5a85573
> contrib/views/wfmanager/src/main/resources/ui/app/index.html df243ad
> contrib/views/wfmanager/src/main/resources/ui/public/assets/custom.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/distcp.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/email.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/fs.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/hive.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/hive2.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/java.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/map-reduce.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/pig.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/shell.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/spark.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/sqoop.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/ssh.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/sub-workflow.png PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58293/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58293: Need a way to indicate the action node type
in workflow manager
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58293/#review171523
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On April 10, 2017, 11:06 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58293/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 11:06 a.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20704
> https://issues.apache.org/jira/browse/AMBARI-20704
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently there's no way for the user to know the action node type from workflow designer page.
> We have added images for each action for easy representation.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 5a85573
> contrib/views/wfmanager/src/main/resources/ui/app/index.html df243ad
> contrib/views/wfmanager/src/main/resources/ui/public/assets/custom.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/distcp.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/email.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/fs.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/hive.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/hive2.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/java.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/map-reduce.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/pig.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/shell.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/spark.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/sqoop.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/ssh.png PRE-CREATION
> contrib/views/wfmanager/src/main/resources/ui/public/assets/sub-workflow.png PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58293/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>