You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/05/24 16:10:23 UTC

[GitHub] trafficserver pull request: TS-4108: Switch SSL metrics to RECD_CO...

GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/661

    TS-4108: Switch SSL metrics to RECD_COUNTER.

    All the SSL metrics registered in SSLUtils.cc are specified as
    RECD_INT, but they are all actually counters and should be specified
    as RECD_COUNTER. They are counters because they all monotonically
    increment and can be sensibly rate-converted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/4108

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #661
    
----
commit 5b5efae070169cb80061d1ec1d2c31799e096e43
Author: James Peach <jp...@apache.org>
Date:   2016-05-24T16:08:06Z

    TS-4108: Switch SSL metrics to RECD_COUNTER.
    
    All the SSL metrics registered in SSLUtils.cc are specified as
    RECD_INT, but they are all actually counters and should be specified
    as RECD_COUNTER. They are counters because they all monotonically
    increment and can be sensibly rate-converted.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-4108: Switch SSL metrics to RECD_CO...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:

    https://github.com/apache/trafficserver/pull/661


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-4108: Switch SSL metrics to RECD_CO...

Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the pull request:

    https://github.com/apache/trafficserver/pull/661#issuecomment-221328309
  
    Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---