You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2013/08/26 10:14:54 UTC

Review Request 13805: CLOUDSTACK-3806: OS Preference can not be set

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13805/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3806


Repository: cloudstack-git


Description
-------

It was setting OS preference correctly, The problem was in host_view. It was using the wrong id for join parameter. It was using host_details.id instead of host_details.host_id. Hence the parameter was not getting updated corretly in view.


Diffs
-----

  setup/db/db/schema-307to410.sql 70cddfd 
  setup/db/db/schema-40to410.sql f1482f8 
  setup/db/db/schema-410to420.sql 4a21898 

Diff: https://reviews.apache.org/r/13805/diff/


Testing
-------

Verified manually on my setup


Thanks,

Anshul Gangwar

Re: Review Request 13805: CLOUDSTACK-3806: OS Preference can not be set

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13805/#review25598
-----------------------------------------------------------


Commit bdbdfd401b0fcd40244e6aedf2ae853853e75e1a in branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bdbdfd4 ]

CLOUDSTACK-3806: There was error in host_view sql, it was using host_details.id for join instead host_details.host_id

Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>


- ASF Subversion and Git Services


On Aug. 26, 2013, 8:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13805/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 8:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3806
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It was setting OS preference correctly, The problem was in host_view. It was using the wrong id for join parameter. It was using host_details.id instead of host_details.host_id. Hence the parameter was not getting updated corretly in view.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-307to410.sql 70cddfd 
>   setup/db/db/schema-40to410.sql f1482f8 
>   setup/db/db/schema-410to420.sql 4a21898 
> 
> Diff: https://reviews.apache.org/r/13805/diff/
> 
> 
> Testing
> -------
> 
> Verified manually on my setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 13805: CLOUDSTACK-3806: OS Preference can not be set

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13805/#review30955
-----------------------------------------------------------


Commit 68a0b27929de4f581f0e3fc411d1e01e8b18f5ea in branch refs/heads/4.3 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=68a0b27 ]

CLOUDSTACK-3806: OS Preference can not be set.


- ASF Subversion and Git Services


On Aug. 26, 2013, 8:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13805/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 8:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3806
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-3806
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It was setting OS preference correctly, The problem was in host_view. It was using the wrong id for join parameter. It was using host_details.id instead of host_details.host_id. Hence the parameter was not getting updated corretly in view.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-307to410.sql 70cddfd 
>   setup/db/db/schema-40to410.sql f1482f8 
>   setup/db/db/schema-410to420.sql 4a21898 
> 
> Diff: https://reviews.apache.org/r/13805/diff/
> 
> 
> Testing
> -------
> 
> Verified manually on my setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 13805: CLOUDSTACK-3806: OS Preference can not be set

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13805/#review25602
-----------------------------------------------------------


Commit c059dacfc49b0757e4cd78498fef0d424a462c54 in branch refs/heads/4.2-forward from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c059dac ]

CLOUDSTACK-3806: There was error in host_view sql, it was using host_details.id for join instead host_details.host_id

Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>


- ASF Subversion and Git Services


On Aug. 26, 2013, 8:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13805/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 8:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3806
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It was setting OS preference correctly, The problem was in host_view. It was using the wrong id for join parameter. It was using host_details.id instead of host_details.host_id. Hence the parameter was not getting updated corretly in view.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-307to410.sql 70cddfd 
>   setup/db/db/schema-40to410.sql f1482f8 
>   setup/db/db/schema-410to420.sql 4a21898 
> 
> Diff: https://reviews.apache.org/r/13805/diff/
> 
> 
> Testing
> -------
> 
> Verified manually on my setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 13805: CLOUDSTACK-3806: OS Preference can not be set

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13805/#review25597
-----------------------------------------------------------

Ship it!


Ship It!

- Sateesh Chodapuneedi


On Aug. 26, 2013, 8:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13805/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 8:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3806
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It was setting OS preference correctly, The problem was in host_view. It was using the wrong id for join parameter. It was using host_details.id instead of host_details.host_id. Hence the parameter was not getting updated corretly in view.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-307to410.sql 70cddfd 
>   setup/db/db/schema-40to410.sql f1482f8 
>   setup/db/db/schema-410to420.sql 4a21898 
> 
> Diff: https://reviews.apache.org/r/13805/diff/
> 
> 
> Testing
> -------
> 
> Verified manually on my setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 13805: CLOUDSTACK-3806: OS Preference can not be set

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13805/#review30964
-----------------------------------------------------------


Commit a782d17caa33d94805d9357a9d85e0bcebe2bac9 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a782d17 ]

CLOUDSTACK-3806: OS Preference can not be set.


- ASF Subversion and Git Services


On Aug. 26, 2013, 8:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13805/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 8:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3806
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-3806
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It was setting OS preference correctly, The problem was in host_view. It was using the wrong id for join parameter. It was using host_details.id instead of host_details.host_id. Hence the parameter was not getting updated corretly in view.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-307to410.sql 70cddfd 
>   setup/db/db/schema-40to410.sql f1482f8 
>   setup/db/db/schema-410to420.sql 4a21898 
> 
> Diff: https://reviews.apache.org/r/13805/diff/
> 
> 
> Testing
> -------
> 
> Verified manually on my setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>