You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/05/07 10:07:54 UTC
[GitHub] [incubator-pegasus] cauchy1988 opened a new pull request, #964: Merge java client
cauchy1988 opened a new pull request, #964:
URL: https://github.com/apache/incubator-pegasus/pull/964
### What problem does this PR solve? <!--add issue link with summary if exists-->
merge pegasus java client into incubator-pegasus
details can be seen in the issue : https://github.com/apache/incubator-pegasus/issues/945
### What is changed and how does it work?
only add the java client repo
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#issuecomment-1120617167
> > Unit test action [1] should also be migrated to this repo.
> > [1] https://github.com/XiaoMi/pegasus-java-client/blob/master/.github/workflows/ci-pr.yaml
>
> i have already added， it just be renamed to a new file ”test_java-client.yml“
OK, I saw it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#issuecomment-1120612490
Unit test action [1] should also be migrated to this repo.
[1] https://github.com/XiaoMi/pegasus-java-client/blob/master/.github/workflows/ci-pr.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#issuecomment-1120611261
Java cient link in README.md should be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#discussion_r867617148
##########
.github/workflows/license_check_java-client.yml:
##########
@@ -0,0 +1,41 @@
+#
Review Comment:
No need this file any more, https://github.com/apache/incubator-pegasus/blob/master/.github/workflows/check_license_header.yaml will do this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#issuecomment-1120611035
I checked the following changes:
- [ ] All files missing APLv2 license header have been added.
- [ ] Package com.xiaomi.infra.pegasus has been rename to org.apache.pegasus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#discussion_r867612572
##########
java-client/README.md:
##########
@@ -0,0 +1,99 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Pegasus Java Client
+
+[](https://travis-ci.org/XiaoMi/pegasus-java-client)
Review Comment:
need update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] cauchy1988 commented on pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
cauchy1988 commented on PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#issuecomment-1120614365
> Unit test action [1] should also be migrated to this repo.
>
> [1] https://github.com/XiaoMi/pegasus-java-client/blob/master/.github/workflows/ci-pr.yaml
i have already added， it just be renamed to a new file ”test_java-client.yml“
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #964: chore: Merge java client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #964:
URL: https://github.com/apache/incubator-pegasus/pull/964#discussion_r867619045
##########
java-client/README.md:
##########
@@ -0,0 +1,99 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Pegasus Java Client
+
+[](https://travis-ci.org/apache/incubator-pegasus)
Review Comment:
Use this one instead.
[](https://github.com/apache/incubator-pegasus/actions/workflows/test_java-client.yml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org