You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/13 09:18:58 UTC

[GitHub] [apisix-ingress-controller] vincenthcui opened a new pull request #366: correctly handle ingress in extensions/v1beta1 version

vincenthcui opened a new pull request #366:
URL: https://github.com/apache/apisix-ingress-controller/pull/366


   get extensions/v1beta1 object when group version is extensions/v1beta1
   
   fix: #365
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   #365 
   ___
   ### Bugfix
   - Description
   
   get extensions/v1beta1 object via networking/v1beta1 interface, it's of course not found
   
   - How to fix?
   
   handle ingress in extensions/v1beta1 correctly
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers merged pull request #366: fix: correctly handle ingress in extensions/v1beta1 version

Posted by GitBox <gi...@apache.org>.
tokers merged pull request #366:
URL: https://github.com/apache/apisix-ingress-controller/pull/366


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] vincenthcui commented on pull request #366: correctly handle ingress in extensions/v1beta1 version

Posted by GitBox <gi...@apache.org>.
vincenthcui commented on pull request #366:
URL: https://github.com/apache/apisix-ingress-controller/pull/366#issuecomment-818665932


   @tokers @gxthrj i have no privileges to merge pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #366: correctly handle ingress in extensions/v1beta1 version

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #366:
URL: https://github.com/apache/apisix-ingress-controller/pull/366#issuecomment-818588189


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#366](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc8adbb) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/2dd7f143343410a610d7dd2fcf1cdd08f0131611?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dd7f14) will **decrease** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #366      +/-   ##
   ==========================================
   - Coverage   42.72%   42.63%   -0.10%     
   ==========================================
     Files          39       38       -1     
     Lines        3476     3481       +5     
   ==========================================
   - Hits         1485     1484       -1     
   - Misses       1820     1826       +6     
     Partials      171      171              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `8.62% <0.00%> (-0.28%)` | :arrow_down: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2dd7f14...fc8adbb](https://codecov.io/gh/apache/apisix-ingress-controller/pull/366?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #366: correctly handle ingress in extensions/v1beta1 version

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #366:
URL: https://github.com/apache/apisix-ingress-controller/pull/366#issuecomment-818611265


   @vincenthcui Thanks for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org