You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mustafasrepo (via GitHub)" <gi...@apache.org> on 2023/09/27 10:15:54 UTC

[GitHub] [arrow-datafusion] mustafasrepo opened a new pull request, #7667: Do not add unnecessary hash repartition to the physical plan

mustafasrepo opened a new pull request, #7667:
URL: https://github.com/apache/arrow-datafusion/pull/7667

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   ## Rationale for this change
   Sometimes in the physical plan I see `RepartitionHash(input_partition=1, output_partition=1)`. In these cases, hash repartitioning is unnecessary. This PR adds a check for this case.
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   Yes, a new test is added to show that unnecessary hash repartition is not added to the physical plan. Even if operator requires hash repartitioning.
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ozankabak commented on pull request #7667: [MINOR]: Do not add unnecessary hash repartition to the physical plan

Posted by "ozankabak (via GitHub)" <gi...@apache.org>.
ozankabak commented on PR #7667:
URL: https://github.com/apache/arrow-datafusion/pull/7667#issuecomment-1739093294

   We did one more review round and added some better commenting as well.
   
   I will go ahead and merge this, we can address any concerns in a follow-on PR should there be any.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ozankabak merged pull request #7667: [MINOR]: Do not add unnecessary hash repartition to the physical plan

Posted by "ozankabak (via GitHub)" <gi...@apache.org>.
ozankabak merged PR #7667:
URL: https://github.com/apache/arrow-datafusion/pull/7667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org