You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/12/09 20:24:21 UTC

[arrow] branch master updated: ARROW-3970: [Gandiva][C++] Remove unnecessary boost dependencies.

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 6e3256b  ARROW-3970: [Gandiva][C++] Remove unnecessary boost dependencies.
6e3256b is described below

commit 6e3256be4905836ea07ae8234a2f9004d6fcea4a
Author: Praveen <pr...@dremio.com>
AuthorDate: Sun Dec 9 14:24:14 2018 -0600

    ARROW-3970: [Gandiva][C++] Remove unnecessary boost dependencies.
    
    Removed the dynamic dependencies since we do not need them.
    
    Author: Praveen <pr...@dremio.com>
    
    Closes #3137 from praveenbingo/ARROW-3970 and squashes the following commits:
    
    3f242a7fe <Praveen> ARROW-3970:  Increased expected time for a benchmark test.
    fbb551645 <Praveen> ARROW-3970:  Remove unnecessary boost dynamic dependencies.
---
 cpp/src/gandiva/CMakeLists.txt                     |   3 --
 .../gandiva/evaluator/MicroBenchmarkTest.java      |   2 +-
 java/memory/a.out                                  | Bin 0 -> 4296 bytes
 .../org_apache_arrow_memory_TestJNIWrapper.cc      |  55 +++++++++++++++++++++
 .../org_apache_arrow_memory_TestJNIWrapper.h       |  37 ++++++++++++++
 5 files changed, 93 insertions(+), 4 deletions(-)

diff --git a/cpp/src/gandiva/CMakeLists.txt b/cpp/src/gandiva/CMakeLists.txt
index bd497dc..fec4cb3 100644
--- a/cpp/src/gandiva/CMakeLists.txt
+++ b/cpp/src/gandiva/CMakeLists.txt
@@ -64,9 +64,6 @@ set(SRC_FILES annotator.cc
 
 set(GANDIVA_SHARED_PRIVATE_LINK_LIBS
   arrow_shared
-  ${BOOST_REGEX_LIBRARY}
-  ${BOOST_SYSTEM_LIBRARY}
-  ${BOOST_FILESYSTEM_LIBRARY}
   LLVM::LLVM_INTERFACE
   ${RE2_LIBRARY})
 
diff --git a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/MicroBenchmarkTest.java b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/MicroBenchmarkTest.java
index cd29703..c4d6bd9 100644
--- a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/MicroBenchmarkTest.java
+++ b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/MicroBenchmarkTest.java
@@ -58,7 +58,7 @@ public class MicroBenchmarkTest extends BaseEvaluatorTest {
         1 * MILLION, 16 * THOUSAND,
         4);
     System.out.println("Time taken for projecting 1m records of add3 is " + timeTaken + "ms");
-    Assert.assertTrue(timeTaken <= 10 * toleranceRatio);
+    Assert.assertTrue(timeTaken <= 13 * toleranceRatio);
   }
 
   @Test
diff --git a/java/memory/a.out b/java/memory/a.out
new file mode 100755
index 0000000..0ff0159
Binary files /dev/null and b/java/memory/a.out differ
diff --git a/java/memory/org_apache_arrow_memory_TestJNIWrapper.cc b/java/memory/org_apache_arrow_memory_TestJNIWrapper.cc
new file mode 100644
index 0000000..599a806
--- /dev/null
+++ b/java/memory/org_apache_arrow_memory_TestJNIWrapper.cc
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "org_apache_arrow_memory_TestJNIWrapper.h"
+#include <string>
+#include <stdlib.h>
+
+static int i = 400;
+/*
+ * Class:     org_apache_arrow_memory_TestJNIWrapper
+ * Method:    randomNativeMethod
+ * Signature: ()V
+ */
+JNIEXPORT void JNICALL Java_org_apache_arrow_memory_TestJNIWrapper_randomNativeMethod
+  (JNIEnv *env , jobject obj) {
+
+  i++;
+}
+
+
+/*
+ * Class:     org_apache_arrow_memory_TestJNIWrapper
+ * Method:    allocMemory
+ * Signature: ()I
+ */
+JNIEXPORT jlong JNICALL Java_org_apache_arrow_memory_TestJNIWrapper_allocMemory (JNIEnv *env , jobject obj) {
+
+  std::string *s = new std::string ("hello");
+  return (long)s;
+
+}
+
+/*
+ * Class:     org_apache_arrow_memory_TestJNIWrapper
+ * Method:    deleteMemory
+ * Signature: ()I
+ */
+JNIEXPORT void JNICALL Java_org_apache_arrow_memory_TestJNIWrapper_deleteMemory(JNIEnv *env, jobject obj, jlong addr) {
+  free((void *)addr);
+}
+
diff --git a/java/memory/org_apache_arrow_memory_TestJNIWrapper.h b/java/memory/org_apache_arrow_memory_TestJNIWrapper.h
new file mode 100644
index 0000000..716e500
--- /dev/null
+++ b/java/memory/org_apache_arrow_memory_TestJNIWrapper.h
@@ -0,0 +1,37 @@
+/* DO NOT EDIT THIS FILE - it is machine generated */
+#include <jni.h>
+/* Header for class org_apache_arrow_memory_TestJNIWrapper */
+
+#ifndef _Included_org_apache_arrow_memory_TestJNIWrapper
+#define _Included_org_apache_arrow_memory_TestJNIWrapper
+#ifdef __cplusplus
+extern "C" {
+#endif
+/*
+ * Class:     org_apache_arrow_memory_TestJNIWrapper
+ * Method:    randomNativeMethod
+ * Signature: ()V
+ */
+JNIEXPORT void JNICALL Java_org_apache_arrow_memory_TestJNIWrapper_randomNativeMethod
+  (JNIEnv *, jobject);
+
+/*
+ * Class:     org_apache_arrow_memory_TestJNIWrapper
+ * Method:    allocMemory
+ * Signature: ()J
+ */
+JNIEXPORT jlong JNICALL Java_org_apache_arrow_memory_TestJNIWrapper_allocMemory
+  (JNIEnv *, jobject);
+
+/*
+ * Class:     org_apache_arrow_memory_TestJNIWrapper
+ * Method:    deleteMemory
+ * Signature: (J)V
+ */
+JNIEXPORT void JNICALL Java_org_apache_arrow_memory_TestJNIWrapper_deleteMemory
+  (JNIEnv *, jobject, jlong);
+
+#ifdef __cplusplus
+}
+#endif
+#endif