You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/12 11:19:49 UTC
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1771: Support for persisting TracingConfiguration into Registry Center
codecov-io commented on pull request #1771:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1771#issuecomment-743741344
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771?src=pr&el=h1) Report
> Merging [#1771](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771?src=pr&el=desc) (8919c44) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/c70a3e7b30ff63833e7e5c9dd70118b594e75e19?el=desc) (c70a3e7) will **decrease** coverage by `0.17%`.
> The diff coverage is `79.77%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1771 +/- ##
============================================
- Coverage 86.10% 85.93% -0.18%
Complexity 110 110
============================================
Files 261 268 +7
Lines 5822 5907 +85
Branches 894 911 +17
============================================
+ Hits 5013 5076 +63
- Misses 486 501 +15
- Partials 323 330 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...b/cloud/scheduler/statistics/StatisticManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9zY2hlZHVsZXIvc3RhdGlzdGljcy9TdGF0aXN0aWNNYW5hZ2VyLmphdmE=) | `87.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tion/TracingStorageConverterNotFoundException.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9leGNlcHRpb24vVHJhY2luZ1N0b3JhZ2VDb252ZXJ0ZXJOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../exception/TracingStorageUnavailableException.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9leGNlcHRpb24vVHJhY2luZ1N0b3JhZ2VVbmF2YWlsYWJsZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...icjob/tracing/listener/TracingListenerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9saXN0ZW5lci9UcmFjaW5nTGlzdGVuZXJGYWN0b3J5LmphdmE=) | `87.50% <50.00%> (-12.50%)` | `0.00 <0.00> (ø)` | |
| [...racing/rdb/datasource/DataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvZGF0YXNvdXJjZS9EYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `80.76% <80.76%> (ø)` | `0.00 <0.00> (?)` | |
| [...job/tracing/rdb/datasource/DataSourceRegistry.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvZGF0YXNvdXJjZS9EYXRhU291cmNlUmVnaXN0cnkuamF2YQ==) | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
| [.../datasource/DataSourceTracingStorageConverter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvZGF0YXNvdXJjZS9EYXRhU291cmNlVHJhY2luZ1N0b3JhZ2VDb252ZXJ0ZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...b/cloud/console/controller/CloudJobController.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL2NvbnRyb2xsZXIvQ2xvdWRKb2JDb250cm9sbGVyLmphdmE=) | `68.31% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/elasticjob/tracing/api/TracingConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9hcGkvVHJhY2luZ0NvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...racing/storage/TracingStorageConverterFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9zdG9yYWdlL1RyYWNpbmdTdG9yYWdlQ29udmVydGVyRmFjdG9yeS5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [12 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771?src=pr&el=footer). Last update [c70a3e7...8919c44](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org