You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/01 13:53:56 UTC

[GitHub] [hadoop-ozone] sodonnel opened a new pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

sodonnel opened a new pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156


   ## What changes were proposed in this pull request?
   
   When SCM or OM is initialized, ensure a property like the following is written to the version file:
   
   layoutVersion=0
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3879
   
   ## How was this patch tested?
   
   Manually inspected the version file after the change.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156#issuecomment-654791797


   I started on the changes to add in the software version too, but in doing that I starting to think about whether we need to actually store it. 
   
   I will discuss with @avijayanhwx and see what conclusion we come to. If we need it, we may as well get it in as part of this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156#issuecomment-652437017


   @avijayanhwx Is this the sort of change you were intending with this Jira? Note that I think it also covers HDDS-3830 too, as both OM and SCM use the same code from reading and writing the VERSION file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156#issuecomment-655586384


   LGTM +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156#issuecomment-654506102


   @sodonnel Thanks for working on this. I am OK with this change. In the future, we may also have to track a different version number which denotes software version. But, for now, this is OK with me. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156#issuecomment-654968796


   > I started on the changes to add in the software version too, but in doing that I starting to think about whether we need to actually store it.
   > 
   > I will discuss with @avijayanhwx and see what conclusion we come to. If we need it, we may as well get it in as part of this change.
   
   Yes, this change as it is can go in.
   
   @swagle We will not have any backward compat issues with respect to layout/software version since the default behavior can handle that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] swagle commented on pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

Posted by GitBox <gi...@apache.org>.
swagle commented on pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156#issuecomment-654527205


   > @sodonnel Thanks for working on this. I am OK with this change. In the future, we may also have to track a different version number which denotes software version. But, for now, this is OK with me.
   
   @avijayanhwx Shouldn't we add whatever we think would be needed now? Introducing it later will not cause incompat?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] sodonnel merged pull request #1156: HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file

Posted by GitBox <gi...@apache.org>.
sodonnel merged pull request #1156:
URL: https://github.com/apache/hadoop-ozone/pull/1156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org